chrome/browser/ui/gtk/browser_window_gtk.cc - Issue 11072002: Combined window positioning and show state determiniation in the WindowSizer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/browser_window_gtk.cc

Issue 11072002: Combined window positioning and show state determiniation in the WindowSizer (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed comments Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller.mm ('k') | chrome/browser/ui/views/ash/browser_non_client_frame_view_ash.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/gtk/browser_window_gtk.cc

diff --git a/chrome/browser/ui/gtk/browser_window_gtk.cc b/chrome/browser/ui/gtk/browser_window_gtk.cc

index e14bbb825fd3c95ba8d34abdd86dc8ebf351b39d..8585c5f9bfc66297f8cd0ab3fbb4c1c833eb30ee 100644

--- a/chrome/browser/ui/gtk/browser_window_gtk.cc

+++ b/chrome/browser/ui/gtk/browser_window_gtk.cc

@@ -1666,9 +1666,10 @@ void BrowserWindowGtk::SetGeometryHints() {

// confused and maximizes the window, but doesn't set the

// GDK_WINDOW_STATE_MAXIMIZED bit. So instead, we keep track of whether to

// maximize and call it after gtk_window_present.

- show_state_after_show_ = chrome::GetSavedWindowShowState(browser_.get());

- gfx::Rect bounds = chrome::GetSavedWindowBounds(browser_.get());

+ gfx::Rect bounds;

+ chrome::GetSavedWindowBoundsAndShowState(browser_.get(),

+ &bounds,

+ &show_state_after_show_);

// We don't blindly call SetBounds here: that sets a forced position

// on the window and we intentionally *don't* do that for normal

// windows. Most programs do not restore their window position on