chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc - Issue 11072002: Combined window positioning and show state determiniation in the WindowSizer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc

Issue 11072002: Combined window positioning and show state determiniation in the WindowSizer (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fixed more build issues Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc

diff --git a/chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc b/chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc

index 74655c04483c7c12fdc42a9960e6d59901ed74be..76ecf882aab8076aa13d1a252eff31b8f84bf4e1 100644

--- a/chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc

+++ b/chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc

@@ -488,8 +488,9 @@ bool CreateOffscreenTabFunction::RunImpl() {

return false;

}

- WindowSizer::GetBrowserWindowBounds(

- std::string(), gfx::Rect(), browser, &window_bounds);

+ ui::WindowShowState show_state;

+ WindowSizer::GetBrowserWindowBoundsAndShowState(

+ std::string(), gfx::Rect(), browser, &window_bounds, &show_state);

int width = window_bounds.width();

if (create_props->HasKey(tabs_keys::kWidthKey))

« no previous file with comments | « no previous file | chrome/browser/extensions/api/tabs/tabs.cc » ('j') | chrome/browser/prefs/pref_service_browsertest.cc » ('J')