Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Side by Side Diff: chrome/browser/prefs/pref_service_browsertest.cc

Issue 11072002: Combined window positioning and show state determiniation in the WindowSizer (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/extensions/api/tabs/tabs.cc ('k') | chrome/browser/ui/browser_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/file_util.h" 8 #include "base/file_util.h"
9 #include "base/json/json_file_value_serializer.h" 9 #include "base/json/json_file_value_serializer.h"
10 #include "base/path_service.h" 10 #include "base/path_service.h"
(...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after
135 EXPECT_TRUE(root_dict->GetInteger(kBrowserWindowPlacement + ".left", 135 EXPECT_TRUE(root_dict->GetInteger(kBrowserWindowPlacement + ".left",
136 &left)); 136 &left));
137 EXPECT_EQ(left, bounds.x()); 137 EXPECT_EQ(left, bounds.x());
138 138
139 int right = 0; 139 int right = 0;
140 EXPECT_TRUE(root_dict->GetInteger(kBrowserWindowPlacement + ".right", 140 EXPECT_TRUE(root_dict->GetInteger(kBrowserWindowPlacement + ".right",
141 &right)); 141 &right));
142 EXPECT_EQ(right, bounds.x() + bounds.width()); 142 EXPECT_EQ(right, bounds.x() + bounds.width());
143 143
144 // Find if launched window is maximized. 144 // Find if launched window is maximized.
145 bool is_window_maximized = 145 bool is_window_maximized = browser()->window()->IsMaximized();
146 chrome::GetSavedWindowShowState(browser()) == ui::SHOW_STATE_MAXIMIZED;
147 bool is_maximized = false; 146 bool is_maximized = false;
148 EXPECT_TRUE(root_dict->GetBoolean(kBrowserWindowPlacement + ".maximized", 147 EXPECT_TRUE(root_dict->GetBoolean(kBrowserWindowPlacement + ".maximized",
149 &is_maximized)); 148 &is_maximized));
150 EXPECT_EQ(is_maximized, is_window_maximized); 149 EXPECT_EQ(is_maximized, is_window_maximized);
151 } 150 }
152 #endif 151 #endif
153 152
154 #if defined(OS_WIN) || defined(OS_MACOSX) 153 #if defined(OS_WIN) || defined(OS_MACOSX)
155 154
156 class PreservedWindowPlacementIsMigrated : public PreferenceServiceTest { 155 class PreservedWindowPlacementIsMigrated : public PreferenceServiceTest {
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
194 EXPECT_TRUE(root_dict->GetInteger(kBrowserWindowPlacement + ".left", 193 EXPECT_TRUE(root_dict->GetInteger(kBrowserWindowPlacement + ".left",
195 &left)); 194 &left));
196 EXPECT_EQ(left, bounds.x()); 195 EXPECT_EQ(left, bounds.x());
197 196
198 int right = 0; 197 int right = 0;
199 EXPECT_TRUE(root_dict->GetInteger(kBrowserWindowPlacement + ".right", 198 EXPECT_TRUE(root_dict->GetInteger(kBrowserWindowPlacement + ".right",
200 &right)); 199 &right));
201 EXPECT_EQ(right, bounds.x() + bounds.width()); 200 EXPECT_EQ(right, bounds.x() + bounds.width());
202 201
203 // Find if launched window is maximized. 202 // Find if launched window is maximized.
204 bool is_window_maximized = 203 bool is_window_maximized = browser()->window()->IsMaximized();
205 chrome::GetSavedWindowShowState(browser()) == ui::SHOW_STATE_MAXIMIZED;
206 bool is_maximized = false; 204 bool is_maximized = false;
207 EXPECT_TRUE(root_dict->GetBoolean(kBrowserWindowPlacement + ".maximized", 205 EXPECT_TRUE(root_dict->GetBoolean(kBrowserWindowPlacement + ".maximized",
208 &is_maximized)); 206 &is_maximized));
209 EXPECT_EQ(is_maximized, is_window_maximized); 207 EXPECT_EQ(is_maximized, is_window_maximized);
210 } 208 }
211 #endif 209 #endif
OLDNEW
« no previous file with comments | « chrome/browser/extensions/api/tabs/tabs.cc ('k') | chrome/browser/ui/browser_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698