Combined window positioning and show state determiniation in the WindowSizer

chrome/browser/ui/window_sizer/window_sizer_ash.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/window_sizer/window_sizer.h"
 
 #include "ash/shell.h"
 #include "ash/wm/window_cycle_controller.h"
 #include "ash/wm/window_util.h"
 #include "base/compiler_specific.h"
@@ skipping 102 matching lines @@
       bounds_in_screen.set_x(work_area.x());
       return true;
     }
   }
   return false;
 }
 
 }  // namespace
 
 bool WindowSizer::GetBoundsOverrideAsh(const gfx::Rect& specified_bounds,
-                                       gfx::Rect* bounds_in_screen) const {
+                                       gfx::Rect* bounds_in_screen,
+                                       ui::WindowShowState& show_state) const {
   *bounds_in_screen = specified_bounds;
   DCHECK(bounds_in_screen->IsEmpty());
 
-  if (!GetSavedWindowBounds(bounds_in_screen))
+  ui::WindowShowState passed_show_state = show_state;
+  if (!GetSavedWindowBounds(bounds_in_screen, show_state))
     GetDefaultWindowBounds(bounds_in_screen);
 
   if (browser_ && browser_->is_type_tabbed()) {
     gfx::Rect work_area =
         monitor_info_provider_->GetMonitorWorkAreaMatching(*bounds_in_screen);
     // This is a window / app. See if there is no window and try to place it.
     int count = GetNumberOfValidTopLevelBrowserWindows(work_area);
     aura::Window* top_window = GetTopWindow(work_area);
+    // The window should not be able to reflect on itself.
+    if (browser_ && top_window == browser_->window()->GetNativeWindow())
+      return true;
+    // If there is no valid other window we take the coordinates as is.
+    if (!count || !top_window)
+      return true;
 
-    // If there is no valid other window we take the coordinates as is.
-    if (!count || !top_window || ash::wm::IsWindowMaximized(top_window))
+    bool maximized = ash::wm::IsWindowMaximized(top_window);
+    // We ignore the saved show state, but look instead for the top level
+    // window's show state.
+    if (passed_show_state == ui::SHOW_STATE_DEFAULT) {
+      show_state = maximized ? ui::SHOW_STATE_MAXIMIZED :
+                               ui::SHOW_STATE_DEFAULT;
+    }
+
+    if (maximized)
       return true;
 
     gfx::Rect other_bounds_in_screen = top_window->GetBoundsInScreen();
     bool move_right =
         other_bounds_in_screen.CenterPoint().x() < work_area.CenterPoint().x();
 
     // In case we have only one window, we move the other window fully to the
     // "other side" - making room for this new window.
     if (count == 1) {
       gfx::Display display =
@@ skipping 36 matching lines @@
   if (default_width > kMaximumWindowWidth) {
     // The window should get centered on the screen and not follow the grid.
     offset_x = (work_area.width() - kMaximumWindowWidth) / 2;
     default_width = kMaximumWindowWidth;
   }
   default_bounds->SetRect(work_area.x() + offset_x,
                           work_area.y() + kDesktopBorderSize,
                           default_width,
                           default_height);
 }