Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Side by Side Diff: chrome/browser/ui/browser_unittest.cc

Issue 11072002: Combined window positioning and show state determiniation in the WindowSizer (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/browser.h" 5 #include "chrome/browser/ui/browser.h"
6 6
7 #include "chrome/app/chrome_command_ids.h" 7 #include "chrome/app/chrome_command_ids.h"
8 #include "chrome/browser/ui/browser_command_controller.h" 8 #include "chrome/browser/ui/browser_command_controller.h"
9 #include "chrome/browser/ui/browser_window_state.h" 9 #include "chrome/browser/ui/browser_window_state.h"
10 #include "chrome/test/base/browser_with_test_window_test.h" 10 #include "chrome/test/base/browser_with_test_window_test.h"
11 #include "content/public/browser/native_web_keyboard_event.h" 11 #include "content/public/browser/native_web_keyboard_event.h"
12 12
13 // Various assertions around setting show state. 13 // Various assertions around setting show state.
14 TEST_F(BrowserWithTestWindowTest, GetSavedWindowShowState) { 14 TEST_F(BrowserWithTestWindowTest, GetSavedWindowShowState) {
15 ui::WindowShowState show_state;
16 chrome::GetSavedWindowBoundsAndShowState(browser(), show_state);
15 // Default show state is SHOW_STATE_DEFAULT. 17 // Default show state is SHOW_STATE_DEFAULT.
16 EXPECT_EQ(ui::SHOW_STATE_DEFAULT, chrome::GetSavedWindowShowState(browser())); 18 EXPECT_EQ(ui::SHOW_STATE_DEFAULT, show_state);
17 19
18 // Explicitly specifying a state should stick though. 20 // Explicitly specifying a state should stick though.
19 browser()->set_initial_show_state(ui::SHOW_STATE_MAXIMIZED); 21 browser()->set_initial_show_state(ui::SHOW_STATE_MAXIMIZED);
20 EXPECT_EQ(ui::SHOW_STATE_MAXIMIZED, 22 chrome::GetSavedWindowBoundsAndShowState(browser(), show_state);
21 chrome::GetSavedWindowShowState(browser())); 23 EXPECT_EQ(ui::SHOW_STATE_MAXIMIZED, show_state);
22 browser()->set_initial_show_state(ui::SHOW_STATE_NORMAL); 24 browser()->set_initial_show_state(ui::SHOW_STATE_NORMAL);
23 EXPECT_EQ(ui::SHOW_STATE_NORMAL, chrome::GetSavedWindowShowState(browser())); 25 chrome::GetSavedWindowBoundsAndShowState(browser(), show_state);
26 EXPECT_EQ(ui::SHOW_STATE_NORMAL, show_state);
24 browser()->set_initial_show_state(ui::SHOW_STATE_MINIMIZED); 27 browser()->set_initial_show_state(ui::SHOW_STATE_MINIMIZED);
25 EXPECT_EQ(ui::SHOW_STATE_MINIMIZED, 28 chrome::GetSavedWindowBoundsAndShowState(browser(), show_state);
26 chrome::GetSavedWindowShowState(browser())); 29 EXPECT_EQ(ui::SHOW_STATE_MINIMIZED, show_state);
27 browser()->set_initial_show_state(ui::SHOW_STATE_FULLSCREEN); 30 browser()->set_initial_show_state(ui::SHOW_STATE_FULLSCREEN);
28 EXPECT_EQ(ui::SHOW_STATE_FULLSCREEN, 31 chrome::GetSavedWindowBoundsAndShowState(browser(), show_state);
29 chrome::GetSavedWindowShowState(browser())); 32 EXPECT_EQ(ui::SHOW_STATE_FULLSCREEN, show_state);
30 } 33 }
31 34
32 TEST_F(BrowserWithTestWindowTest, IsReservedCommandOrKey) { 35 TEST_F(BrowserWithTestWindowTest, IsReservedCommandOrKey) {
33 #if defined(OS_CHROMEOS) 36 #if defined(OS_CHROMEOS)
34 const content::NativeWebKeyboardEvent event(ui::ET_KEY_PRESSED, 37 const content::NativeWebKeyboardEvent event(ui::ET_KEY_PRESSED,
35 false, 38 false,
36 ui::VKEY_F1, 39 ui::VKEY_F1,
37 0, 40 0,
38 base::Time::Now().ToDoubleT()); 41 base::Time::Now().ToDoubleT());
39 // F1-4 keys are reserved on Chrome OS. 42 // F1-4 keys are reserved on Chrome OS.
40 EXPECT_TRUE(browser()->command_controller()->IsReservedCommandOrKey(IDC_BACK, 43 EXPECT_TRUE(browser()->command_controller()->IsReservedCommandOrKey(IDC_BACK,
41 event)); 44 event));
42 // ..unless |command_id| is -1. crbug.com/122978 45 // ..unless |command_id| is -1. crbug.com/122978
43 EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(-1, 46 EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(-1,
44 event)); 47 event));
45 #endif 48 #endif
46 } 49 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698