Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: chrome/browser/gtk/location_bar_view_gtk.h

Issue 1107007: Extension context menu refactor (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/gtk/location_bar_view_gtk.h
===================================================================
--- chrome/browser/gtk/location_bar_view_gtk.h (revision 41960)
+++ chrome/browser/gtk/location_bar_view_gtk.h (working copy)
@@ -15,6 +15,7 @@
#include "base/scoped_vector.h"
#include "chrome/browser/autocomplete/autocomplete_edit.h"
#include "chrome/browser/autocomplete/autocomplete_edit_view_gtk.h"
+#include "chrome/browser/extensions/extension_context_menu_model.h"
#include "chrome/browser/extensions/image_loading_tracker.h"
#include "chrome/browser/gtk/info_bubble_gtk.h"
#include "chrome/browser/gtk/menu_gtk.h"
@@ -34,7 +35,6 @@
class ContentSettingImageModel;
class ContentSettingBubbleGtk;
class ExtensionAction;
-class ExtensionActionContextMenuModel;
class GtkThemeProvider;
class Profile;
class SkBitmap;
@@ -46,9 +46,7 @@
public LocationBarTesting,
public NotificationObserver {
public:
- LocationBarViewGtk(CommandUpdater* command_updater,
- ToolbarModel* toolbar_model,
- const BubblePositioner* bubble_positioner,
+ LocationBarViewGtk(const BubblePositioner* bubble_positioner,
Browser* browser_);
virtual ~LocationBarViewGtk();
@@ -171,7 +169,8 @@
DISALLOW_COPY_AND_ASSIGN(ContentSettingImageViewGtk);
};
- class PageActionViewGtk : public ImageLoadingTracker::Observer {
+ class PageActionViewGtk : public ImageLoadingTracker::Observer,
+ public ExtensionContextMenuModel::PopupDelegate {
public:
PageActionViewGtk(
LocationBarViewGtk* owner, Profile* profile,
@@ -199,6 +198,9 @@
// Simulate left mouse click on the page action button.
void TestActivatePageAction();
+ // Overridden from ExtensionContextMenuModel::PopupDelegate:
+ virtual void InspectPopup(ExtensionAction* action);
+
private:
static gboolean OnButtonPressedThunk(GtkWidget* sender,
GdkEvent* event,
@@ -254,7 +256,7 @@
// The context menu view and model for this extension action.
scoped_ptr<MenuGtk> context_menu_;
- scoped_ptr<ExtensionActionContextMenuModel> context_menu_model_;
+ scoped_ptr<ExtensionContextMenuModel> context_menu_model_;
DISALLOW_COPY_AND_ASSIGN(PageActionViewGtk);
};

Powered by Google App Engine
This is Rietveld 408576698