Show selection handles around selected text.

content/browser/android/content_view_core_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_ANDROID_CONTENT_VIEW_CORE_IMPL_H_
 #define CONTENT_BROWSER_ANDROID_CONTENT_VIEW_CORE_IMPL_H_
 
 #include <vector>
 
 #include "base/android/jni_helper.h"
@@ skipping 178 matching lines @@
                         const std::string& text,
                         int selection_start, int selection_end,
                         int composition_start, int composition_end,
                         bool show_ime_if_needed);
   void SetTitle(const string16& title);
 
   bool HasFocus();
   void ConfirmTouchEvent(bool handled);
   void DidSetNeedTouchEvents(bool need_touch_events);
   void OnSelectionChanged(const std::string& text);
-  void OnSelectionBoundsChanged(int startx,
-                                int starty,
-                                base::i18n::TextDirection start_dir,
-                                int endx,
-                                int endy,
-                                base::i18n::TextDirection end_dir);
+  virtual void OnSelectionBoundsChanged(
+      const gfx::Rect& start_rect, base::i18n::TextDirection start_dir,
+      const gfx::Rect& end_rect, base::i18n::TextDirection end_dir) OVERRIDE;

[nilesh, 2012/10/10 20:35:42]

Unless I am missing something, you need to add this to the public interface as
well. It will break the clang bot?

[Iain Merrick, 2012/10/11 09:51:23]

Argh, good catch! I need to add content_view_core.h to this patch.

 
   void StartContentIntent(const GURL& content_url);
 
   // --------------------------------------------------------------------------
   // Methods called from native code
   // --------------------------------------------------------------------------
 
   gfx::Rect GetBounds() const;
 
  private:
@@ skipping 43 matching lines @@
   ui::WindowAndroid* window_android_;
 
   DISALLOW_COPY_AND_ASSIGN(ContentViewCoreImpl);
 };
 
 bool RegisterContentViewCore(JNIEnv* env);
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_ANDROID_CONTENT_VIEW_CORE_IMPL_H_