Fix for out-of-sync scale factor issue

chrome/browser/ui/startup/startup_browser_creator_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/startup/startup_browser_creator_impl.h"
 
 #include <algorithm>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 77 matching lines @@
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_contents_view.h"
 #include "grit/locale_settings.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/gfx/rect.h"
 #include "ui/gfx/screen.h"
 
 #if defined(USE_ASH)
 #include "ash/launcher/launcher_types.h"
+#include "ash/shell.h"
+#include "ui/aura/window.h"
 #endif
 
 #if defined(OS_MACOSX)
 #include "base/mac/mac_util.h"
 #include "chrome/browser/ui/cocoa/keystone_infobar_delegate.h"
 #endif
 
 #if defined(TOOLKIT_GTK)
 #include "chrome/browser/ui/gtk/gtk_util.h"
 #endif
@@ skipping 691 matching lines @@
     browser = new Browser(Browser::CreateParams(profile_));
   } else {
 #if defined(TOOLKIT_GTK)
     // Setting the time of the last action on the window here allows us to steal
     // focus, which is what the user wants when opening a new tab in an existing
     // browser window.
     gtk_util::SetWMLastUserActionTime(browser->window()->GetNativeWindow());
 #endif
   }
 
+#if defined(USE_ASH)
+  // Set the browser's root window to be an active root window now
+  // so that that web contents can determine correct scale factor for
+  // the renderer. crbug.com/155201.
+  ash::Shell::GetInstance()->set_active_root_window(

[sky, 2012/10/12 14:31:40]

I don't understand why this is necessary. Why is the renderer keying off the
active RootWindow? Wouldn't this mean if a timer kicks in and tries to create a
renderer that isn't in the active rootwindow it'll get the wrong scale?

[oshima, 2012/10/12 16:04:46]

We're not passing enough information for WebContentsViewAura::CreateView
to be able to tell in which display/scale factor it is being created. Thus,
window_->SetParent(NULL) in this method will pick active root window.

And when you create a new browser on 1x display, while an active root window
is on 2x display, it will first create renderer with 2x scale factor, and then
switch to 1x when it is added to a browser. And there is a potential race
condition when you switch scale factor right after its created, which can result
in showing 1x on the web contents. (refreshing by moving/resizing fixes
the issue, according to the report). Even without the race, it'd be waste to
render at different scale factor and then drop the result.
It will use the correct scale but issue is the race and waste, but above race
happen only when you switch immediately after it's created. Waste may still
happen though.

RIght fix is to pass enough information to WebContentsViewAura::CreateView
so that it can determine the correct scale factor, but it will requite a lot of
changes in many places, and it's risky to merge to 23. I filed a bug
(crbug.com/155443) and will work on this for 25.

And I'll update the comment to be more clear.

+      browser->window()->GetNativeWindow()->GetRootWindow());
+#endif
+
   // In kiosk mode, we want to always be fullscreen, so switch to that now.
   if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kKioskMode))
     chrome::ToggleFullscreenMode(browser);
 
   bool first_tab = true;
   for (size_t i = 0; i < tabs.size(); ++i) {
     // We skip URLs that we'd have to launch an external protocol handler for.
     // This avoids us getting into an infinite loop asking ourselves to open
     // a URL, should the handler be (incorrectly) configured to be us. Anyone
     // asking us to open such a URL should really ask the handler directly.
@@ skipping 182 matching lines @@
         // New:
         prefs->GetString(prefs::kHomePage),
         prefs->GetBoolean(prefs::kHomePageIsNewTabPage),
         prefs->GetBoolean(prefs::kShowHomeButton),
         // Backup:
         backup_homepage,
         backup_homepage_is_ntp,
         backup_show_home_button));
   }
 }