Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issue 11066045: Extract files for implementing unit tests from ash_unittests. (Closed)

Created:
8 years, 2 months ago by mazda
Modified:
8 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Extract files for implementing unit tests from ash_unittests. This change is needed for adding tests in http://codereview.chromium.org/11033038/. BUG=154183 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=160573

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -19 lines) Patch
M ash/ash.gyp View 1 3 chunks +32 lines, -19 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
mazda
8 years, 2 months ago (2012-10-05 21:18:08 UTC) #1
sky
LGTM
8 years, 2 months ago (2012-10-05 21:35:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mazda@chromium.org/11066045/1
8 years, 2 months ago (2012-10-05 21:41:50 UTC) #3
commit-bot: I haz the power
Retried try job too often for step(s) interactive_ui_tests
8 years, 2 months ago (2012-10-05 22:48:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mazda@chromium.org/11066045/1
8 years, 2 months ago (2012-10-05 22:57:39 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
8 years, 2 months ago (2012-10-05 23:07:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mazda@chromium.org/11066045/18002
8 years, 2 months ago (2012-10-06 00:28:04 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 2 months ago (2012-10-06 02:24:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mazda@chromium.org/11066045/18002
8 years, 2 months ago (2012-10-06 04:00:17 UTC) #9
commit-bot: I haz the power
8 years, 2 months ago (2012-10-06 07:51:13 UTC) #10
Change committed as 160573

Powered by Google App Engine
This is Rietveld 408576698