Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 1106002: Fix bug when generating a fast smi loop.... (Closed)

Created:
10 years, 9 months ago by fschneider
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix bug when generating a fast smi loop. We may encounter an invalid frame after generating code for the loop body in case the loop body ends in an unconditional return. Before setting the type information for the loop variable we need to check for a valid frame. Committed: http://code.google.com/p/v8/source/detail?r=4182

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M src/ia32/codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/loopcount.js View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
fschneider
10 years, 9 months ago (2010-03-18 14:27:19 UTC) #1
Søren Thygesen Gjesse
10 years, 9 months ago (2010-03-18 14:28:22 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698