Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: chrome/browser/extensions/app_host_installer_impl_win.cc

Issue 11054006: Make application shortcuts point to app_host.exe, install App Host during app installation. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Stylistic changes: typedef and function renames. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/app_host_installer_impl_win.cc
diff --git a/chrome/browser/extensions/app_host_installer_impl_win.cc b/chrome/browser/extensions/app_host_installer_impl_win.cc
new file mode 100644
index 0000000000000000000000000000000000000000..fade623c3d0e8b95607478c9de50b0f487d3d8c7
--- /dev/null
+++ b/chrome/browser/extensions/app_host_installer_impl_win.cc
@@ -0,0 +1,204 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// AppHostInstallerImpl checks the presence of app_host.exe, and launches
+// the installer if missing. The check must be performed on the FILE thread.
+// The installation is also launched on the FILE thread as an asynchronous
+// process. Once installation completes, QuickEnableWatcher is notified.
+// AppHostInstallerImpl::FinishOnCallerThread() is called in the end,
+// which notifies the caller via a completion callback on the original
+// calling thread, and then destroys the AppHostInstallerImpl instance.
+
+#include "chrome/browser/extensions/app_host_installer_impl_win.h"
+
+#include <windows.h>
+#include "base/bind.h"
+#include "base/callback.h"
+#include "base/logging.h"
+#include "base/process_util.h"
+#include "base/string16.h"
+#include "base/win/registry.h"
+#include "chrome/installer/launcher_support/chrome_launcher_support.h"
+
+namespace {
+
+using extensions::app_host_installer::OnAppHostInstallationCompleteCallback;
+
+// TODO(huangs) Refactor the constants: http://crbug.com/148538
+const wchar_t kGoogleRegClientsKey[] = L"Software\\Google\\Update\\Clients";
+
+// Copied from chrome_appid.cc.
+const wchar_t kBinariesAppGuid[] = L"{4DC8B4CA-1BDA-483e-B5FA-D3C12E15B62D}";
+
+// Copied from google_update_constants.cc
+const wchar_t kRegCommandLineField[] = L"CommandLine";
+const wchar_t kRegCommandsKey[] = L"Commands";
+
+// Copied from util_constants.cc.
+const wchar_t kCmdQuickEnableApplicationHost[] =
+ L"quick-enable-application-host";
+
+// QuickEnableDelegate handles the completion event of App Host installation
+// via the quick-enable-application host command. At construction, the
+// class is given |callback_| that takes a bool parameter.
+// Upon completion, |callback_| is invoked, and is passed a boolean to
+// indicate success or failure of installation.
+class QuickEnableDelegate : public base::win::ObjectWatcher::Delegate {
+ public:
+ explicit QuickEnableDelegate(
+ const OnAppHostInstallationCompleteCallback& callback);
+
+ ~QuickEnableDelegate();
+
+ // base::win::ObjectWatcher::Delegate implementation.
+ virtual void OnObjectSignaled(HANDLE object) OVERRIDE;
+
+ private:
+ OnAppHostInstallationCompleteCallback callback_;
+
+ DISALLOW_COPY_AND_ASSIGN(QuickEnableDelegate);
+};
+
+QuickEnableDelegate::QuickEnableDelegate(
+ const OnAppHostInstallationCompleteCallback& callback)
+ : callback_(callback) {}
+
+QuickEnableDelegate::~QuickEnableDelegate() {}
+
+void QuickEnableDelegate::OnObjectSignaled(HANDLE object) {
+ int exit_code = 0;
+ base::TerminationStatus status(
+ base::GetTerminationStatus(object, &exit_code));
+ if (status == base::TERMINATION_STATUS_NORMAL_TERMINATION) {
+ callback_.Run(true);
+ } else {
+ LOG(ERROR) << "App Host install failed, status = " << status
+ << ", exit code = " << exit_code;
+ callback_.Run(false);
+ }
+ callback_.Reset();
+}
+
+// Reads the path to app_host.exe from the value "UninstallString" within the
+// App Host's "ClientState" registry key. Returns an empty string if the path
+// does not exist or cannot be read.
+string16 GetQuickEnableAppHostCommand(bool system_level) {
+ HKEY root_key = system_level ? HKEY_LOCAL_MACHINE : HKEY_CURRENT_USER;
+ string16 subkey(kGoogleRegClientsKey);
+ subkey.append(1, L'\\').append(kBinariesAppGuid)
+ .append(1, L'\\').append(kRegCommandsKey)
+ .append(1, L'\\').append(kCmdQuickEnableApplicationHost);
+ base::win::RegKey reg_key;
+ string16 cmd;
+ if (reg_key.Open(root_key, subkey.c_str(),
+ KEY_QUERY_VALUE) == ERROR_SUCCESS) {
+ // If read is unsuccessful, |cmd| remains empty.
+ reg_key.ReadValue(kRegCommandLineField, &cmd);
+ }
+ return cmd;
+}
+
+// Launches the Google Update command to quick-enable App Host.
+// Returns true if the command is launched.
+bool LaunchQuickEnableAppHost(base::win::ScopedHandle* process) {
+ DCHECK(!process->IsValid());
+ bool success = false;
+
+ string16 cmd_str(GetQuickEnableAppHostCommand(true));
+ if (cmd_str.empty()) // Try user-level if absent from system-level.
+ cmd_str = GetQuickEnableAppHostCommand(false);
+ if (!cmd_str.empty()) {
+ VLOG(1) << "Quick-enabling application host: " << cmd_str;
+ if (!base::LaunchProcess(cmd_str, base::LaunchOptions(),
+ process->Receive())) {
+ LOG(ERROR) << "Failed to quick-enable application host.";
+ }
+ success = process->IsValid();
+ }
+ return success;
+}
+
+} // namespace
+
+namespace extensions {
+
+namespace app_host_installer {
+
+using content::BrowserThread;
+
+// static
+void AppHostInstallerImpl::EnsureAppHostInstalled(
+ const OnAppHostInstallationCompleteCallback& completion_callback) {
+ BrowserThread::ID caller_thread_id;
+ if (!BrowserThread::GetCurrentThreadIdentifier(&caller_thread_id)) {
+ NOTREACHED();
+ return;
+ }
+
+ // AppHostInstalerImpl will delete itself
+ (new AppHostInstallerImpl(completion_callback, caller_thread_id))->
+ EnsureAppHostInstalledInternal();
+}
+
+AppHostInstallerImpl::AppHostInstallerImpl(
+ const OnAppHostInstallationCompleteCallback& completion_callback,
+ BrowserThread::ID caller_thread_id)
+ : completion_callback_(completion_callback),
+ caller_thread_id_(caller_thread_id) {}
+
+AppHostInstallerImpl::~AppHostInstallerImpl() {}
+
+void AppHostInstallerImpl::EnsureAppHostInstalledInternal() {
+ if (!BrowserThread::CurrentlyOn(BrowserThread::FILE)) {
+ // Redo on FILE thread.
+ if (!BrowserThread::PostTask(BrowserThread::FILE, FROM_HERE,
+ base::Bind(&AppHostInstallerImpl::EnsureAppHostInstalledInternal,
+ base::Unretained(this)))) {
+ FinishOnCallerThread(false);
+ }
+ return;
+ }
+
+ if (chrome_launcher_support::IsAppHostPresent())
+ FinishOnCallerThread(true);
+ else
+ InstallAppHostOnFileThread();
+}
+
+void AppHostInstallerImpl::InstallAppHostOnFileThread() {
+ DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
+ DCHECK(!process_.IsValid());
+ if (!LaunchQuickEnableAppHost(&process_)) {
+ FinishOnCallerThread(false);
+ } else {
+ DCHECK(process_.IsValid());
+ DCHECK(!delegate_.get());
+ watcher_.StopWatching();
+ delegate_.reset(new QuickEnableDelegate(
+ base::Bind(&AppHostInstallerImpl::FinishOnCallerThread,
+ base::Unretained(this))));
+ watcher_.StartWatching(process_, delegate_.get());
+ }
+}
+
+void AppHostInstallerImpl::FinishOnCallerThread(bool success) {
+ if (!BrowserThread::CurrentlyOn(caller_thread_id_)) {
+ // Redo on caller thread.
+ if (!BrowserThread::PostTask(caller_thread_id_, FROM_HERE,
+ base::Bind(&AppHostInstallerImpl::FinishOnCallerThread,
+ base::Unretained(this),
+ success))) {
+ // This could happen in Shutdown....
+ delete this;
+ }
+ return;
+ }
+
+ completion_callback_.Run(success);
+ delete this;
+}
+
+} // namespace app_host_installer
+
+} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698