Index: chrome/browser/extensions/crx_installer.cc |
diff --git a/chrome/browser/extensions/crx_installer.cc b/chrome/browser/extensions/crx_installer.cc |
index 040e353d098d4a95f43a556f0f4e96a215968a18..c1a1ae72d3983ca4c38336abe3bc582ec210217d 100644 |
--- a/chrome/browser/extensions/crx_installer.cc |
+++ b/chrome/browser/extensions/crx_installer.cc |
@@ -20,6 +20,7 @@ |
#include "base/utf_string_conversions.h" |
#include "base/version.h" |
#include "chrome/browser/browser_process.h" |
+#include "chrome/browser/extensions/app_host_installer.h" |
#include "chrome/browser/extensions/convert_user_script.h" |
#include "chrome/browser/extensions/convert_web_app.h" |
#include "chrome/browser/extensions/extension_error_reporter.h" |
@@ -463,7 +464,7 @@ void CrxInstaller::ConfirmInstall() { |
} else { |
if (!BrowserThread::PostTask( |
BrowserThread::FILE, FROM_HERE, |
- base::Bind(&CrxInstaller::CompleteInstall, this))) |
+ base::Bind(&CrxInstaller::BeginInstall, this))) |
NOTREACHED(); |
} |
return; |
@@ -472,7 +473,7 @@ void CrxInstaller::ConfirmInstall() { |
void CrxInstaller::InstallUIProceed() { |
if (!BrowserThread::PostTask( |
BrowserThread::FILE, FROM_HERE, |
- base::Bind(&CrxInstaller::CompleteInstall, this))) |
+ base::Bind(&CrxInstaller::BeginInstall, this))) |
NOTREACHED(); |
Release(); // balanced in ConfirmInstall(). |
@@ -500,9 +501,8 @@ void CrxInstaller::InstallUIAbort(bool user_initiated) { |
// should go to zero and we die. The destructor will clean up the temp dir. |
} |
-void CrxInstaller::CompleteInstall() { |
+void CrxInstaller::BeginInstall() { |
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE)); |
- |
if (!current_version_.empty()) { |
Version current_version(current_version_); |
if (current_version.CompareTo(*(extension_->version())) > 0) { |
@@ -515,6 +515,25 @@ void CrxInstaller::CompleteInstall() { |
} |
} |
+ app_host_installer::InstallAppHostIfNecessary(*extension_, |
+ base::Bind(&CrxInstaller::OnAppHostInstallationComplete, this)); |
+} |
+ |
+void CrxInstaller::OnAppHostInstallationComplete(bool success) { |
+ DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE)); |
+ if (!success) { |
+ ReportFailureFromFileThread( |
grt (UTC plus 2)
2012/10/24 15:59:18
nit: use less vertical space:
ReportFailureFro
huangs
2012/10/24 18:52:45
Done.
|
+ CrxInstallerError( |
+ l10n_util::GetStringUTF16( |
+ IDS_EXTENSION_APP_HOST_INSTALL_ERROR))); |
+ return; |
+ } |
+ |
+ CompleteInstall(); |
+} |
+ |
+void CrxInstaller::CompleteInstall() { |
+ DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE)); |
// See how long extension install paths are. This is important on |
// windows, because file operations may fail if the path to a file |
// exceeds a small constant. See crbug.com/69693 . |