Make application shortcuts point to app_host.exe, install App Host during app installation.

chrome/browser/extensions/app_host_installer.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_EXTENSIONS_APP_HOST_INSTALLER_H_
+#define CHROME_BROWSER_EXTENSIONS_APP_HOST_INSTALLER_H_
+
+#include "base/callback_forward.h"
+
+namespace extensions {
+
+class Extension;
+
+namespace app_host_installer {

[grt (UTC plus 2), 2012/10/24 15:59:18]

this doesn't follow the chromium namespace convention. if this code belongs in
the app_host_installer namespace, then it should also be in the
app_host_installer directory under the extensions directory.

https://groups.google.com/a/chromium.org/d/msg/chromium-dev/RVps606IB_g/ZLes1...

[huangs, 2012/10/24 18:52:45]

We still need to find a good place to place these, so not changing this yet (at
least keeping as placeholder).

+
+// Installs the App Host if it is absent, but is required for the given
+// extension on the current platform.
+// Calls |completion_callback| on the original calling thread after checks
+// and (possible) installation are complete, with a boolean that will be false
+// iff the installation was required but failed.
+void InstallAppHostIfNecessary(const Extension& extension,

[erikwright (departed), 2012/10/24 15:33:28]

need to wrap both parameters if you can't indent the second one (you can't).

So line-break after (

[huangs, 2012/10/24 18:52:45]

Done.

+    const base::Callback<void(bool)>& completion_callback);
+
+}  // namespace app_host_installer
+
+}  // namespace extensions
+
+#endif  // CHROME_BROWSER_EXTENSIONS_APP_HOST_INSTALLER_H_