Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1041)

Unified Diff: sync/notifier/sync_invalidation_listener.cc

Issue 11052007: Rename ModelType/ObjectIdStateMap to InvalidationMap. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/notifier/sync_invalidation_listener.cc
diff --git a/sync/notifier/sync_invalidation_listener.cc b/sync/notifier/sync_invalidation_listener.cc
index 9e8b2ad130dafd48e09cc7afe16d48a81354468f..c6c3b19f907b5a9fce0ef025876e09ae978e9430 100644
--- a/sync/notifier/sync_invalidation_listener.cc
+++ b/sync/notifier/sync_invalidation_listener.cc
@@ -161,9 +161,9 @@ void SyncInvalidationListener::Invalidate(
if (invalidation.has_payload())
payload = invalidation.payload();
- ObjectIdStateMap id_state_map;
- id_state_map[id].payload = payload;
- EmitInvalidation(id_state_map);
+ ObjectIdInvalidationMap invalidation_map;
+ invalidation_map[id].payload = payload;
+ EmitInvalidation(invalidation_map);
// TODO(akalin): We should really acknowledge only after we get the
// updates from the sync server. (see http://crbug.com/78462).
client->Acknowledge(ack_handle);
@@ -177,9 +177,9 @@ void SyncInvalidationListener::InvalidateUnknownVersion(
DCHECK_EQ(client, invalidation_client_.get());
DVLOG(1) << "InvalidateUnknownVersion";
- ObjectIdStateMap id_state_map;
- id_state_map[object_id].payload = std::string();
- EmitInvalidation(id_state_map);
+ ObjectIdInvalidationMap invalidation_map;
+ invalidation_map[object_id].payload = std::string();
+ EmitInvalidation(invalidation_map);
// TODO(akalin): We should really acknowledge only after we get the
// updates from the sync server. (see http://crbug.com/78462).
client->Acknowledge(ack_handle);
@@ -194,21 +194,18 @@ void SyncInvalidationListener::InvalidateAll(
DCHECK_EQ(client, invalidation_client_.get());
DVLOG(1) << "InvalidateAll";
- ObjectIdStateMap id_state_map;
- for (ObjectIdSet::const_iterator it = registered_ids_.begin();
- it != registered_ids_.end(); ++it) {
- id_state_map[*it].payload = std::string();
- }
- EmitInvalidation(id_state_map);
+ const ObjectIdInvalidationMap& invalidation_map =
+ ObjectIdSetToInvalidationMap(registered_ids_, std::string());
+ EmitInvalidation(invalidation_map);
// TODO(akalin): We should really acknowledge only after we get the
// updates from the sync server. (see http://crbug.com/76482).
client->Acknowledge(ack_handle);
}
void SyncInvalidationListener::EmitInvalidation(
- const ObjectIdStateMap& id_state_map) {
+ const ObjectIdInvalidationMap& invalidation_map) {
DCHECK(CalledOnValidThread());
- delegate_->OnInvalidate(id_state_map);
+ delegate_->OnInvalidate(invalidation_map);
}
void SyncInvalidationListener::InformRegistrationStatus(

Powered by Google App Engine
This is Rietveld 408576698