Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Unified Diff: cc/layer_impl.cc

Issue 11048044: cc: Switch to Chromium DCHECKs and LOGs (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: rebase Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/layer_impl.cc
diff --git a/cc/layer_impl.cc b/cc/layer_impl.cc
index 6d513a242c71f507d54465380b81160c22ea5c94..81a8e2b7e8b18e6a78d84dd27f3bc24da7b96175 100644
--- a/cc/layer_impl.cc
+++ b/cc/layer_impl.cc
@@ -15,6 +15,7 @@
#include "CCScrollbarAnimationController.h"
#include "CCSettings.h"
#include "TraceEvent.h"
+#include "cc/dcheck.h"
using WebKit::WebTransformationMatrix;
@@ -54,21 +55,19 @@ CCLayerImpl::CCLayerImpl(int id)
, m_debugBorderWidth(0)
, m_drawTransformIsAnimating(false)
, m_screenSpaceTransformIsAnimating(false)
-#ifndef NDEBUG
+#if CC_DCHECK_ENABLED
, m_betweenWillDrawAndDidDraw(false)
#endif
, m_layerAnimationController(CCLayerAnimationController::create(this))
{
- ASSERT(CCProxy::isImplThread());
- ASSERT(m_layerId > 0);
+ CC_DCHECK(CCProxy::isImplThread());
+ CC_DCHECK(m_layerId > 0);
}
CCLayerImpl::~CCLayerImpl()
{
- ASSERT(CCProxy::isImplThread());
-#ifndef NDEBUG
- ASSERT(!m_betweenWillDrawAndDidDraw);
-#endif
+ CC_DCHECK(CCProxy::isImplThread());
+ CC_DCHECK(!m_betweenWillDrawAndDidDraw);
}
void CCLayerImpl::addChild(scoped_ptr<CCLayerImpl> child)
@@ -106,7 +105,7 @@ void CCLayerImpl::clearChildList()
void CCLayerImpl::createRenderSurface()
{
- ASSERT(!m_renderSurface);
+ CC_DCHECK(!m_renderSurface);
m_renderSurface = adoptPtr(new CCRenderSurface(this));
setRenderTarget(this);
}
@@ -127,17 +126,17 @@ scoped_ptr<CCSharedQuadState> CCLayerImpl::createSharedQuadState() const
void CCLayerImpl::willDraw(CCResourceProvider*)
{
-#ifndef NDEBUG
+#if CC_DCHECK_ENABLED
// willDraw/didDraw must be matched.
- ASSERT(!m_betweenWillDrawAndDidDraw);
+ CC_DCHECK(!m_betweenWillDrawAndDidDraw);
m_betweenWillDrawAndDidDraw = true;
#endif
}
void CCLayerImpl::didDraw(CCResourceProvider*)
{
-#ifndef NDEBUG
- ASSERT(m_betweenWillDrawAndDidDraw);
+#if CC_DCHECK_ENABLED
+ CC_DCHECK(m_betweenWillDrawAndDidDraw);
m_betweenWillDrawAndDidDraw = false;
#endif
}
@@ -168,7 +167,7 @@ CCRenderPass::Id CCLayerImpl::nextContributingRenderPassId(CCRenderPass::Id) con
CCResourceProvider::ResourceId CCLayerImpl::contentsResourceId() const
{
- ASSERT_NOT_REACHED();
+ NOTREACHED();
return 0;
}
« no previous file with comments | « cc/layer_impl.h ('k') | cc/layer_iterator.h » ('j') | cc/yuv_video_draw_quad.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698