Decouple EventClientImpl and root window. Check containers on the same root window as focused windo…

ash/wm/event_client_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/event_client_impl.h"
 
 #include "ash/shell.h"
 #include "ash/shell_window_ids.h"
-#include "ui/aura/root_window.h"
 #include "ui/aura/window.h"
 
 namespace ash {
 namespace internal {
 
-EventClientImpl::EventClientImpl(aura::RootWindow* root_window)
-    : root_window_(root_window) {
-  aura::client::SetEventClient(root_window_, this);
+EventClientImpl::EventClientImpl() {
 }
 
 EventClientImpl::~EventClientImpl() {
-  aura::client::SetEventClient(root_window_, NULL);
 }
 
 bool EventClientImpl::CanProcessEventsWithinSubtree(
     const aura::Window* window) const {
-  if (Shell::GetInstance()->IsScreenLocked()) {
+  aura::RootWindow* root_window = window ?
+      const_cast<aura::RootWindow*>(window->GetRootWindow()) : NULL;

[oshima, 2012/10/06 06:57:36]

GetContainer doesn't change the state of root window so const_cast is safe here,
I can change the argument to non const if you prefer that way. Let me know.

[Daniel Erat, 2012/10/06 14:00:19]

can you just make GetContainer() take a const window, or is that change more
difficult?

[oshima, 2012/10/06 17:20:58]

It returns non const aura::Window*, so we can't just make it const.
We can add new one though (I added it in new patch)
Please let me know what you think.

+  if (Shell::GetInstance()->IsScreenLocked() && root_window) {
     aura::Window* lock_screen_containers = Shell::GetContainer(
-        root_window_,
+        root_window,
         kShellWindowId_LockScreenContainersContainer);
     aura::Window* lock_background_containers = Shell::GetContainer(
-        root_window_,
+        root_window,
         kShellWindowId_LockScreenBackgroundContainer);
     aura::Window* lock_screen_related_containers = Shell::GetContainer(
-        root_window_,
+        root_window,
         kShellWindowId_LockScreenRelatedContainersContainer);
     return lock_screen_containers->Contains(window) ||
         lock_background_containers->Contains(window) ||
         lock_screen_related_containers->Contains(window);
   }
   return true;
 }
 
 }  // namespace internal
 }  // namespace ash