Browser Plugin: Fixed browser process crash on embedder reload.

content/browser/web_contents/web_contents_impl.cc

Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 9291e9f115c90b8a1a3f70aa66eab23b76a33dd8..59acabbe51cc955b768c2b23985ce05b825d77f9 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -2379,7 +2379,6 @@ void WebContentsImpl::OnBrowserPluginCreateGuest(
   // For more info, see comment above classes BrowserPluginEmbedder and
   // BrowserPluginGuest.

[Charlie Reis, 2012/10/02 23:22:18]

Similarly, we should update this to say that this is only for the first
CreateGuest call, and subsequent ones are handled in
BrowserPluginEmbedderHelper.

How does that happen, anyway?  Is it just that BrowserPluginEmbedderHelper
consumes the IPC message so it never makes it to WebContentsImpl after that? 
That's worth being a little more explicit about in this comment, since it's very
implicit in the code.

[Fady Samuel, 2012/10/03 01:48:16]

Done.

   CHECK(!browser_plugin_embedder_.get());
-
   browser_plugin_embedder_.reset(
       content::BrowserPluginEmbedder::Create(this, GetRenderViewHost()));
   browser_plugin_embedder_->CreateGuest(GetRenderViewHost(),
@@ -2388,16 +2387,6 @@ void WebContentsImpl::OnBrowserPluginCreateGuest(
                                         persist_storage);
 }
 
-void WebContentsImpl::OnBrowserPluginNavigateGuest(
-    int instance_id,
-    const std::string& src,
-    const BrowserPluginHostMsg_ResizeGuest_Params& resize_params) {
-  browser_plugin_embedder_->NavigateGuest(GetRenderViewHost(),
-                                          instance_id,
-                                          src,
-                                          resize_params);
-}
-
 // Notifies the RenderWidgetHost instance about the fact that the page is
 // loading, or done loading and calls the base implementation.
 void WebContentsImpl::SetIsLoading(bool is_loading,