Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Unified Diff: visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/XamlParser.cs

Issue 11044024: Implement multi-core builds in MSVS (Closed) Base URL: http://nativeclient-sdk.googlecode.com/svn/trunk/src
Patch Set: fix nits Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/XamlParser.cs
diff --git a/visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/XamlParser.cs b/visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/XamlParser.cs
index 776fa8b1694bb8b009ad4132d63a83aa61c8e113..050c56ed852a3870e69c75927fdd7b9fe119530c 100644
--- a/visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/XamlParser.cs
+++ b/visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/XamlParser.cs
@@ -39,7 +39,7 @@ namespace NaCl.Build.CPPTasks
{
{ typeof(StringListProperty), GenerateArgumentStringList },
{ typeof(StringProperty), GenerateArgumentString },
- { typeof(IntProperty), GenerateArgumentString },
+ { typeof(IntProperty), GenerateArgumentInt },
{ typeof(BoolProperty), GenerateArgumentBool },
{ typeof(EnumProperty), GenerateArgumentEnum }
};
@@ -126,6 +126,12 @@ namespace NaCl.Build.CPPTasks
AppendStringValue(builder, property, casted.Subtype, value);
}
+ private void GenerateArgumentInt(CommandLineBuilder builder, BaseProperty property, string value)
+ {
+ // Currently we only have one Int property and it doesn't correspond to a
+ // command line arguemnt (ProcessorNumber) so we ignore it here.
+ }
+
private void GenerateArgumentBool(CommandLineBuilder builder, BaseProperty property, string value)
{
if (value == "true")

Powered by Google App Engine
This is Rietveld 408576698