Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: chrome/browser/ui/views/constrained_window_frame_simple.h

Issue 11044020: Make Web Intents picker in Views conform to latest mocks (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Address comments Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/constrained_window_frame_simple.h
diff --git a/chrome/browser/ui/views/constrained_window_frame_simple.h b/chrome/browser/ui/views/constrained_window_frame_simple.h
index 3a141a558150a93dce89a80077f7257dd5cadcab..8d545f55f65a54b777b2782d0be49e700c187843 100644
--- a/chrome/browser/ui/views/constrained_window_frame_simple.h
+++ b/chrome/browser/ui/views/constrained_window_frame_simple.h
@@ -14,7 +14,6 @@ class ConstrainedWindowViews;
namespace views {
class ImageButton;
class Label;
-class LayoutManager;
}
////////////////////////////////////////////////////////////////////////////////
@@ -24,24 +23,9 @@ class LayoutManager;
class ConstrainedWindowFrameSimple : public views::NonClientFrameView,
public views::ButtonListener {
public:
- // Contains references to relevant views in the header. The header
- // must be non-NULL.
- struct HeaderViews {
- HeaderViews(views::View* header,
- views::Label* title_label,
- views::Button* close_button);
-
- views::View* header;
- views::Label* title_label;
- views::Button* close_button;
- };
-
explicit ConstrainedWindowFrameSimple(ConstrainedWindowViews* container);
virtual ~ConstrainedWindowFrameSimple();
- // SetHeaderView assumes ownership of the passed parameter.
- void SetHeaderView(HeaderViews* header_views);
-
private:
// Overridden from views::NonClientFrameView:
virtual gfx::Rect GetBoundsForClientView() const OVERRIDE;
@@ -53,6 +37,7 @@ class ConstrainedWindowFrameSimple : public views::NonClientFrameView,
virtual void ResetWindowControls() OVERRIDE;
virtual void UpdateWindowIcon() OVERRIDE;
virtual void UpdateWindowTitle() OVERRIDE;
+ virtual void OnBoundsChanged(const gfx::Rect& previous_bounds) OVERRIDE;
// Overridden from View:
virtual gfx::Size GetPreferredSize() OVERRIDE;
@@ -61,15 +46,10 @@ class ConstrainedWindowFrameSimple : public views::NonClientFrameView,
virtual void ButtonPressed(views::Button* sender,
const ui::Event& event) OVERRIDE;
- HeaderViews* CreateDefaultHeaderView();
-
- views::ImageButton* CreateCloseButton();
-
ConstrainedWindowViews* container_;
-
- views::LayoutManager* layout_;
-
- scoped_ptr<HeaderViews> header_views_;
+ views::Label* title_label_;
+ views::ImageButton* close_button_;
+ views::View* header_;
Peter Kasting 2012/10/16 02:26:53 Tiny nit: Declaring |header_| first as we did befo
please use gerrit instead 2012/10/16 16:29:38 Done.
DISALLOW_COPY_AND_ASSIGN(ConstrainedWindowFrameSimple);
};

Powered by Google App Engine
This is Rietveld 408576698