chrome/browser/ui/intents/web_intent_picker_controller.cc - Issue 11044020: Make Web Intents picker in Views conform to latest mocks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/intents/web_intent_picker_controller.cc

Issue 11044020: Make Web Intents picker in Views conform to latest mocks (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Address comments Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/intents/web_intent_picker_controller.cc

diff --git a/chrome/browser/ui/intents/web_intent_picker_controller.cc b/chrome/browser/ui/intents/web_intent_picker_controller.cc

index d25caabe711c34cc9a0c7910dd728cdeea68b612..b87bbd011867c0452c8a95d033665fe87797b525 100644

--- a/chrome/browser/ui/intents/web_intent_picker_controller.cc

+++ b/chrome/browser/ui/intents/web_intent_picker_controller.cc

@@ -559,9 +559,8 @@ void WebIntentPickerController::DispatchToInstalledExtension(

// services. For now, just choose the first.

const webkit_glue::WebIntentServiceData& service_data = services[0];

- picker_model_->AddInstalledService(

- service_data.title, service_data.service_url,

- service_data.disposition);

+ picker_model_->RemoveSuggestedExtension(extension_id);

+ AddServiceToModel(service_data);

OnServiceChosen(service_data.service_url, service_data.disposition,

kEnableDefaults);

AsyncOperationFinished();