Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1368)

Issue 11043022: plugins: Stub implementation for accepting dragged data. (Closed)

Created:
8 years, 2 months ago by sadrul
Modified:
8 years, 2 months ago
Reviewers:
brettw
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

plugins: Stub implementation for accepting dragged data. A complete implementation for browser-plugin will be added in a subsequent CL. BUG=120264

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -1 line) Patch
M content/renderer/browser_plugin/browser_plugin.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin.cc View 1 3 chunks +10 lines, -1 line 0 comments Download
M webkit/plugins/npapi/webplugin_impl.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M webkit/plugins/npapi/webplugin_impl.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_webplugin_impl.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_webplugin_impl.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M webkit/plugins/webview_plugin.h View 1 1 chunk +6 lines, -0 lines 1 comment Download
M webkit/plugins/webview_plugin.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sadrul
8 years, 2 months ago (2012-10-03 19:51:21 UTC) #1
sadrul
ping :)
8 years, 2 months ago (2012-10-05 14:49:11 UTC) #2
brettw
I'm not really clear on what's happening here. WebPlugin has a function handleDragStatusUpdate that you ...
8 years, 2 months ago (2012-10-09 22:18:45 UTC) #3
sadrul
8 years, 2 months ago (2012-10-09 22:20:27 UTC) #4
On 2012/10/09 22:18:45, brettw wrote:
> I'm not really clear on what's happening here. WebPlugin has a function
> handleDragStatusUpdate that you want to implement in some place? Why are we
> adding it in these 4 places when the current default implementation is working
> OK? Why not just add it in the one place you care about?

Oh, sorry. The initial webkit patch did not have a default implementation for
it. But I ended up landing with the default implementation, so this patch is no
longer necessary. Closing.

Powered by Google App Engine
This is Rietveld 408576698