chrome/common/extensions/api/declarative_web_request.json - Issue 11038031: Adding condition attributes for request headers to Declarative WebRequest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/declarative_web_request.json

Issue 11038031: Adding condition attributes for request headers to Declarative WebRequest (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Removed 0-sized arrays. Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc ('K') | « chrome/browser/extensions/api/declarative_webrequest/webrequest_constants.cc ('k') | chrome/test/data/extensions/api_test/webrequest/test_declarative.js » ('j') | chrome/test/data/extensions/api_test/webrequest/test_declarative.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/declarative_web_request.json

diff --git a/chrome/common/extensions/api/declarative_web_request.json b/chrome/common/extensions/api/declarative_web_request.json

index ff78b640f0b96543f6f6be044bb6449100e57b6d..048673c75aaba1d4c0bed8ff85482cb2d082763c 100644

--- a/chrome/common/extensions/api/declarative_web_request.json

+++ b/chrome/common/extensions/api/declarative_web_request.json

@@ -88,6 +88,18 @@

"description": "Matches if the MIME media type of a response (from the HTTP Content-Type header) is <em>not</em> contained in the list.",

"items": { "type": "string" }

+ "requestHeaders": {

+ "type": "array",

+ "optional": true,

+ "description": "Matches if some of the request headers is matched by one of the HeaderFilters.",

+ "items": { "$ref": "HeaderFilter" }

+ },

+ "excludeRequestHeaders": {

+ "type": "array",

+ "optional": true,

+ "description": "Matches if none of the request headers is matched by one of the HeaderFilters.",

battre 2012/10/05 12:50:03 nit: "by one of the" -> "by any of the"

vabr (Chromium) 2012/10/05 15:56:53 Done, also for excludeResponseHeaders.

+ "items": { "$ref": "HeaderFilter" }

+ },

"responseHeaders": {

"type": "array",

"optional": true,