Adding condition attributes for request headers to Declarative WebRequest

chrome/test/data/extensions/api_test/webrequest/test_declarative.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var onRequest = chrome.declarativeWebRequest.onRequest;
 var AddResponseHeader =
     chrome.declarativeWebRequest.AddResponseHeader;
 var RequestMatcher = chrome.declarativeWebRequest.RequestMatcher;
 var CancelRequest = chrome.declarativeWebRequest.CancelRequest;
 var RedirectByRegEx = chrome.declarativeWebRequest.RedirectByRegEx;
@@ skipping 88 matching lines @@
       [ {'conditions': [
            new RequestMatcher({
              'url': {
                  'pathSuffix': ".html",
                  'ports': [testServerPort, [1000, 2000]],
                  'schemes': ["http"]
              },
              'resourceType': ["main_frame"],
              'contentType': ["text/plain"],
              'excludeContentType': ["image/png"],
-             'responseHeaders': [{ nameContains: ["content", "type"] } ],
+             'responseHeaders': [{ nameContains: ["content", "type"] }],
              'excludeResponseHeaders': [{ valueContains: "nonsense" }] })],
          'actions': [new CancelRequest()]}
       ],
       function() {navigateAndWait(getURLHttpWithHeaders());}
     );
   },
 
   function testRedirectRequest() {
     ignoreUnexpected = true;
     expect(
@@ skipping 377 matching lines @@
               chrome.test.fail("Redirect was not prevented. Status: " +
                   this.status + ", responseText: " + this.responseText);
             }
           }
           req.open("GET", getURLHttpXHRData(), asynchronous);
           req.send(null);
         });
       }
     );
   },
+
+  function testRequestHeaders() {
+    ignoreUnexpected = true;
+    expect(
+      [
+        { label: "onErrorOccurred",
+          event: "onErrorOccurred",
+          details: {
+            url: getURLHttpWithHeaders(),
+            fromCache: false,
+            error: "net::ERR_BLOCKED_BY_CLIENT"
+          }
+        },
+      ],
+      [ ["onErrorOccurred"] ]);
+    onRequest.addRules(
+      [ {'conditions': [
+           new RequestMatcher({
+             'url': {
+                 'pathSuffix': ".html",
+                 'ports': [testServerPort, [1000, 2000]],
+                 'schemes': ["http"]
+             },
+             'requestHeaders': [{ nameContains: "" }],
+             'excludeRequestHeaders': [{ valueContains: ["", "value123"] }]
+              })],
+         'actions': [new CancelRequest()]}
+      ],
+      function() {navigateAndWait(getURLHttpWithHeaders());}

[battre, 2012/10/05 12:50:03]

This URL returns a response with specific headers. The request headers are the
default headers. I think this test would pass if requestHeaders and
excludeRequestHeaders would do nothing.

[battre, 2012/10/05 15:45:49]

As discussed, I think that the unit tests in combination with this are
sufficient.

[vabr (Chromium), 2012/10/05 15:56:53]

OK. I at least changed the URL to something more simple, to avoid confusion with
the headers. It does not matter what the URL is, as long as it is valid.

+    );
+  },
   ]);