Implement Chrome Extension TabCapture API.

chrome/common/extensions/feature_switch.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/feature_switch.h"
 
 #include "base/command_line.h"
 #include "base/lazy_instance.h"
 #include "base/string_util.h"
 #include "chrome/common/chrome_switches.h"
+#include "content/public/common/content_switches.h"
 
 namespace extensions {
 
 namespace {
 
 class CommonSwitches {
  public:
   CommonSwitches()
       : action_box(
             switches::kActionBox,
             FeatureSwitch::DEFAULT_ENABLED),
         easy_off_store_install(
             switches::kEasyOffStoreExtensionInstall,
             FeatureSwitch::DEFAULT_DISABLED),
         extensions_in_action_box(
             switches::kExtensionsInActionBox,
             FeatureSwitch::DEFAULT_DISABLED),
         script_badges(
             switches::kScriptBadges,
             FeatureSwitch::DEFAULT_DISABLED),
         script_bubble(
             switches::kScriptBubble,
+            FeatureSwitch::DEFAULT_DISABLED),
+        tab_capture(
+            switches::kEnableTabCapture,
             FeatureSwitch::DEFAULT_DISABLED) {
 // Disabling easy off-store installation is not yet implemented for Aura. Not
 // sure what the Aura equivalent for this UI is.
 #if defined(USE_AURA)
     easy_off_store_install.SetOverrideValue(FeatureSwitch::OVERRIDE_ENABLED);
 #endif
 
     if (!action_box.IsEnabled()){
       extensions_in_action_box.SetOverrideValue(
           FeatureSwitch::OVERRIDE_DISABLED);
     }
   }
 
   FeatureSwitch action_box;
   FeatureSwitch easy_off_store_install;
   FeatureSwitch extensions_in_action_box;
   FeatureSwitch script_badges;
   FeatureSwitch script_bubble;
+  FeatureSwitch tab_capture;
 };
 
 base::LazyInstance<CommonSwitches> g_common_switches =
     LAZY_INSTANCE_INITIALIZER;
 
 }  // namespace
 
 
 FeatureSwitch* FeatureSwitch::action_box() {
   return &g_common_switches.Get().action_box;
 }
 FeatureSwitch* FeatureSwitch::easy_off_store_install() {
   return &g_common_switches.Get().easy_off_store_install;
 }
 FeatureSwitch* FeatureSwitch::extensions_in_action_box() {
   return &g_common_switches.Get().extensions_in_action_box;
 }
 FeatureSwitch* FeatureSwitch::script_badges() {
   return &g_common_switches.Get().script_badges;
 }
 FeatureSwitch* FeatureSwitch::script_bubble() {
   return &g_common_switches.Get().script_bubble;
 }
+FeatureSwitch* FeatureSwitch::tab_capture() {
+  return &g_common_switches.Get().tab_capture;
+}
 
 
 FeatureSwitch::ScopedOverride::ScopedOverride(FeatureSwitch* feature,
                                               bool override_value)
     : feature_(feature),
       previous_value_(feature->GetOverrideValue()) {
   feature_->SetOverrideValue(
       override_value ? OVERRIDE_ENABLED : OVERRIDE_DISABLED);
 }
 
@@ skipping 34 matching lines @@
 
   if (switch_value == "0")
     return false;
 
   if (!default_value_ && command_line_->HasSwitch(GetLegacyEnableFlag()))
     return true;
 
   if (default_value_ && command_line_->HasSwitch(GetLegacyDisableFlag()))
     return false;
 
+  if (command_line_->HasSwitch(switch_name_))

[Aaron Boodman, 2012/10/17 20:28:14]

Should not be necessary (GetLegacyEnableFlag() should be doing the same thing).

[justinlin, 2012/10/17 23:41:48]

The problem is the key is switches::kEnableTabCapture == "enable-tab-capture".
So, the legacy checks will check "enable-enable-tab-capture", but not the actual
key.

[Aaron Boodman, 2012/10/18 22:51:35]

So change kEnableTabCapture to "tab-capture" (probably makes sense to change
constant name too, to just kTabCapture).

[justinlin, 2012/10/19 00:03:33]

Done.

+    return true;
+
   return default_value_;
 }
 
 std::string FeatureSwitch::GetLegacyEnableFlag() const {
   return std::string("enable-") + switch_name_;
 }
 
 std::string FeatureSwitch::GetLegacyDisableFlag() const {
   return std::string("disable-") + switch_name_;
 }
 
 void FeatureSwitch::SetOverrideValue(OverrideValue override_value) {
   override_value_ = override_value;
 }
 
 FeatureSwitch::OverrideValue FeatureSwitch::GetOverrideValue() const {
   return override_value_;
 }
 
 }  // namespace extensions