Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Unified Diff: content/browser/android/surface_texture_peer_browser_impl.cc

Issue 11038015: Android: lazy initialization for method id. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Moves to MethodID Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/surface_texture_peer_browser_impl.cc
diff --git a/content/browser/android/surface_texture_peer_browser_impl.cc b/content/browser/android/surface_texture_peer_browser_impl.cc
index a68286df08b6e8fc247b8d5a5e9a6e6429f303ea..4639127fce8caa3c5ff6195f6fb55a36f947c0cb 100644
--- a/content/browser/android/surface_texture_peer_browser_impl.cc
+++ b/content/browser/android/surface_texture_peer_browser_impl.cc
@@ -12,6 +12,8 @@
#include "jni/BrowserProcessSurfaceTexture_jni.h"
#include "media/base/android/media_player_bridge.h"
+using base::android::MethodID;
+
namespace content {
// Pass a java surface object to the MediaPlayerBridge object
@@ -76,8 +78,9 @@ void SurfaceTexturePeerBrowserImpl::EstablishSurfaceTexturePeer(
} else {
base::android::ScopedJavaLocalRef<jclass> cls(
base::android::GetClass(env, "android/view/Surface"));
- jmethodID constructor = GetMethodID(env, cls, "<init>",
- "(Landroid/graphics/SurfaceTexture;)V");
+ jmethodID constructor = MethodID::Get<
+ MethodID::METHODTYPE_NORMAL, MethodID::EXCEPTIONCHECK_YES>(
+ env, cls.obj(), "<init>", "(Landroid/graphics/SurfaceTexture;)V");
ScopedJavaLocalRef<jobject> tmp(env,
env->NewObject(cls.obj(), constructor, j_surface_texture));
jobject surface = env->NewGlobalRef(tmp.obj());

Powered by Google App Engine
This is Rietveld 408576698