Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Unified Diff: content/browser/renderer_host/java/java_method.cc

Issue 11038015: Android: lazy initialization for method id. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/java/java_method.cc
diff --git a/content/browser/renderer_host/java/java_method.cc b/content/browser/renderer_host/java/java_method.cc
index 6f6878c790a94d07cd7a5d5fad836efd49720ed5..4d770f3196ffc8243473be0ca5ba73920535aa4e 100644
--- a/content/browser/renderer_host/java/java_method.cc
+++ b/content/browser/renderer_host/java/java_method.cc
@@ -13,9 +13,8 @@
using base::android::AttachCurrentThread;
using base::android::ConvertJavaStringToUTF8;
using base::android::GetClass;
-using base::android::GetMethodID;
using base::android::GetMethodIDFromClassName;
-using base::android::GetStaticMethodID;
+using base::android::MethodID;
using base::android::ScopedJavaGlobalRef;
using base::android::ScopedJavaLocalRef;
@@ -214,9 +213,9 @@ void JavaMethod::EnsureTypesAndIDAreSetUp() const {
kReturningInteger));
bool is_static = env->CallStaticBooleanMethod(
g_java_lang_reflect_modifier_class.Get().obj(),
- GetStaticMethodID(env, g_java_lang_reflect_modifier_class.Get(),
- kIsStatic,
- kIntegerReturningBoolean),
+ MethodID::Get<MethodID::TYPE_STATIC>(
+ env, g_java_lang_reflect_modifier_class.Get().obj(), kIsStatic,
+ kIntegerReturningBoolean),
modifiers);
// Get the ID for this method.
@@ -227,8 +226,9 @@ void JavaMethod::EnsureTypesAndIDAreSetUp() const {
kGetDeclaringClass,
kReturningJavaLangClass))));
id_ = is_static ?
- GetStaticMethodID(env, declaring_class, name_.c_str(),
- signature.c_str()) :
- GetMethodID(env, declaring_class, name_.c_str(), signature.c_str());
+ MethodID::Get<MethodID::TYPE_STATIC>(
+ env, declaring_class.obj(), name_.c_str(), signature.c_str()) :
+ MethodID::Get<MethodID::TYPE_INSTANCE>(
+ env, declaring_class.obj(), name_.c_str(), signature.c_str());
java_method_.Reset();
}
« no previous file with comments | « content/browser/geolocation/location_api_adapter_android.cc ('k') | content/common/android/surface_callback.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698