Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4125)

Unified Diff: chrome/browser/android/provider/chrome_browser_provider.cc

Issue 11038015: Android: lazy initialization for method id. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/provider/chrome_browser_provider.cc
diff --git a/chrome/browser/android/provider/chrome_browser_provider.cc b/chrome/browser/android/provider/chrome_browser_provider.cc
index fd10a9fa9d21916e0f078e036e1e9fcbfcff7b9b..5cb9fa2d02fdacba6dcc82f924640b722a391be5 100644
--- a/chrome/browser/android/provider/chrome_browser_provider.cc
+++ b/chrome/browser/android/provider/chrome_browser_provider.cc
@@ -48,7 +48,7 @@ using base::android::ConvertJavaStringToUTF8;
using base::android::ConvertUTF8ToJavaString;
using base::android::ConvertUTF16ToJavaString;
using base::android::GetClass;
-using base::android::GetMethodID;
+using base::android::MethodID;
using base::android::JavaRef;
using base::android::ScopedJavaGlobalRef;
using base::android::ScopedJavaLocalRef;
@@ -119,15 +119,16 @@ void ConvertBookmarkNode(
jlong ConvertJLongObjectToPrimitive(JNIEnv* env, jobject long_obj) {
ScopedJavaLocalRef<jclass> jlong_clazz = GetClass(env, "java/lang/Long");
- jmethodID long_value = GetMethodID(env, jlong_clazz, "longValue", "()J");
+ jmethodID long_value = MethodID::Get<MethodID::TYPE_INSTANCE>(
+ env, jlong_clazz.obj(), "longValue", "()J");
return env->CallLongMethod(long_obj, long_value, NULL);
}
jboolean ConvertJBooleanObjectToPrimitive(JNIEnv* env, jobject boolean_object) {
ScopedJavaLocalRef<jclass> jboolean_clazz =
GetClass(env, "java/lang/Boolean");
- jmethodID boolean_value =
- GetMethodID(env, jboolean_clazz, "booleanValue", "()Z");
+ jmethodID boolean_value = MethodID::Get<MethodID::TYPE_INSTANCE>(
+ env, jboolean_clazz.obj(), "booleanValue", "()Z");
return env->CallBooleanMethod(boolean_object, boolean_value, NULL);
}
@@ -139,7 +140,8 @@ base::Time ConvertJlongToTime(jlong value) {
jint ConvertJIntegerToJint(JNIEnv* env, jobject integer_obj) {
ScopedJavaLocalRef<jclass> jinteger_clazz =
GetClass(env, "java/lang/Integer");
- jmethodID int_value = GetMethodID(env, jinteger_clazz, "intValue", "()I");
+ jmethodID int_value = MethodID::Get<MethodID::TYPE_INSTANCE>(
+ env, jinteger_clazz.obj(), "intValue", "()I");
return env->CallIntMethod(integer_obj, int_value, NULL);
}
« no previous file with comments | « chrome/browser/android/chrome_web_contents_delegate_android.cc ('k') | chrome/browser/history/android/sqlite_cursor.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698