Android: lazy initialization for method id.

chrome/browser/android/provider/chrome_browser_provider.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/provider/chrome_browser_provider.h"
 
 #include <list>
 #include <utility>
 
 #include "base/android/jni_android.h"
@@ skipping 30 matching lines @@
 #include "ui/gfx/favicon_size.h"
 
 using base::android::AttachCurrentThread;
 using base::android::CheckException;
 using base::android::ClearException;
 using base::android::ConvertJavaStringToUTF16;
 using base::android::ConvertJavaStringToUTF8;
 using base::android::ConvertUTF8ToJavaString;
 using base::android::ConvertUTF16ToJavaString;
 using base::android::GetClass;
-using base::android::GetMethodID;
+using base::android::MethodID;
 using base::android::JavaRef;
 using base::android::ScopedJavaGlobalRef;
 using base::android::ScopedJavaLocalRef;
 using content::BrowserThread;
 
 // After refactoring the following class hierarchy has been created in order
 // to avoid repeating code again for the same basic kind of tasks, to enforce
 // the correct thread usage and to prevent known race conditions and deadlocks.
 //
 // - RunOnUIThreadBlocking: auxiliary class to run methods in the UI thread
@@ skipping 50 matching lines @@
       ConvertUTF16ToJavaString(env, node->GetTitle()));
 
   jnode->Reset(
       Java_BookmarkNode_create(
           env, node->id(), (jint) node->type(), title.obj(), url.obj(),
           parent_node.obj()));
 }
 
 jlong ConvertJLongObjectToPrimitive(JNIEnv* env, jobject long_obj) {
   ScopedJavaLocalRef<jclass> jlong_clazz = GetClass(env, "java/lang/Long");
-  jmethodID long_value = GetMethodID(env, jlong_clazz, "longValue", "()J");
+  jmethodID long_value = MethodID::Get<
+      MethodID::METHODTYPE_NORMAL, MethodID::EXCEPTIONCHECK_YES>(
+          env, jlong_clazz.obj(), "longValue", "()J");
   return env->CallLongMethod(long_obj, long_value, NULL);
 }
 
 jboolean ConvertJBooleanObjectToPrimitive(JNIEnv* env, jobject boolean_object) {
   ScopedJavaLocalRef<jclass> jboolean_clazz =
       GetClass(env, "java/lang/Boolean");
-  jmethodID boolean_value =
-      GetMethodID(env, jboolean_clazz, "booleanValue", "()Z");
+  jmethodID boolean_value = MethodID::Get<
+      MethodID::METHODTYPE_NORMAL, MethodID::EXCEPTIONCHECK_YES>(
+          env, jboolean_clazz.obj(), "booleanValue", "()Z");
   return env->CallBooleanMethod(boolean_object, boolean_value, NULL);
 }
 
 base::Time ConvertJlongToTime(jlong value) {
   return base::Time::UnixEpoch() +
       base::TimeDelta::FromMilliseconds((int64)value);
 }
 
 jint ConvertJIntegerToJint(JNIEnv* env, jobject integer_obj) {
   ScopedJavaLocalRef<jclass> jinteger_clazz =
       GetClass(env, "java/lang/Integer");
-  jmethodID int_value = GetMethodID(env, jinteger_clazz, "intValue", "()I");
+  jmethodID int_value = MethodID::Get<
+      MethodID::METHODTYPE_NORMAL, MethodID::EXCEPTIONCHECK_YES>(
+          env, jinteger_clazz.obj(), "intValue", "()I");
   return env->CallIntMethod(integer_obj, int_value, NULL);
 }
 
 std::vector<string16> ConvertJStringArrayToString16Array(JNIEnv* env,
                                                          jobjectArray array) {
   std::vector<string16> results;
   if (array) {
     jsize len = env->GetArrayLength(array);
     for (int i = 0; i < len; i++) {
       results.push_back(ConvertJavaStringToUTF16(env,
@@ skipping 1414 matching lines @@
       chrome::NOTIFICATION_HISTORY_KEYWORD_SEARCH_TERM_UPDATED) {
     JNIEnv* env = AttachCurrentThread();
     ScopedJavaLocalRef<jobject> obj = weak_java_provider_.get(env);
     if (obj.is_null())
       return;
     Java_ChromeBrowserProvider_onSearchTermChanged(env, obj.obj());
   } else if (type == chrome::NOTIFICATION_TEMPLATE_URL_SERVICE_LOADED) {
     template_loaded_event_.Signal();
   }
 }