Android: lazy initialization for method id.

ui/base/clipboard/clipboard_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/base/clipboard/clipboard.h"
 
 #include "base/android/jni_string.h"
 #include "base/lazy_instance.h"
 #include "base/stl_util.h"
 #include "base/synchronization/lock.h"
 #include "base/utf_string_conversions.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "ui/gfx/size.h"
 
 // Important note:
 // The Android clipboard system only supports text format. So we use the
 // Android system when some text is added or retrieved from the system. For
 // anything else, we currently store the value in some process wide static
 // variable protected by a lock. So the (non-text) clipboard will only work
 // within the same process.
 
 using base::android::AttachCurrentThread;
 using base::android::CheckException;
 using base::android::ClearException;
 using base::android::ConvertJavaStringToUTF16;
 using base::android::ConvertJavaStringToUTF8;
 using base::android::GetClass;
-using base::android::GetMethodID;
+using base::android::MethodID;
 using base::android::ScopedJavaLocalRef;
 
 namespace ui {
 
 namespace {
 // Various formats we support.
 const char kPlainTextFormat[] = "text";
 const char kHTMLFormat[] = "html";
 const char kRTFFormat[] = "rtf";
 const char kBitmapFormat[] = "bitmap";
@@ skipping 29 matching lines @@
 
   // Get the context.
   jobject context = base::android::GetApplicationContext();
   DCHECK(context);
 
   // Get the context class.
   ScopedJavaLocalRef<jclass> context_class =
       GetClass(env, "android/content/Context");
 
   // Get the system service method.
-  jmethodID get_system_service = GetMethodID(env, context_class,
-      "getSystemService",  "(Ljava/lang/String;)Ljava/lang/Object;");
+  jmethodID get_system_service = MethodID::Get<MethodID::TYPE_INSTANCE>(
+      env, context_class.obj(), "getSystemService",
+      "(Ljava/lang/String;)Ljava/lang/Object;");
 
   // Retrieve the system service.
   ScopedJavaLocalRef<jstring> service_name(env, env->NewStringUTF("clipboard"));
   clipboard_manager_.Reset(env, env->CallObjectMethod(context,
       get_system_service, service_name.obj()));
   DCHECK(clipboard_manager_.obj() && !ClearException(env));
 
   // Retain a few methods we'll keep using.
   ScopedJavaLocalRef<jclass> clipboard_class =
       GetClass(env, "android/text/ClipboardManager");
-  set_text_ = GetMethodID(env, clipboard_class,
-                          "setText", "(Ljava/lang/CharSequence;)V");
-  get_text_ = GetMethodID(env, clipboard_class,
-                          "getText", "()Ljava/lang/CharSequence;");
-  has_text_ = GetMethodID(env, clipboard_class,
-                          "hasText", "()Z");
+  set_text_ = MethodID::Get<MethodID::TYPE_INSTANCE>(
+      env, clipboard_class.obj(), "setText", "(Ljava/lang/CharSequence;)V");
+  get_text_ = MethodID::Get<MethodID::TYPE_INSTANCE>(
+      env, clipboard_class.obj(), "getText", "()Ljava/lang/CharSequence;");
+  has_text_ = MethodID::Get<MethodID::TYPE_INSTANCE>(
+      env, clipboard_class.obj(), "hasText", "()Z");
 
   // Will need to call toString as CharSequence is not always a String.
   ScopedJavaLocalRef<jclass> charsequence_class =
       GetClass(env, "java/lang/CharSequence");
-  to_string_ = GetMethodID(env, charsequence_class,
-                           "toString", "()Ljava/lang/String;");
+  to_string_ = MethodID::Get<MethodID::TYPE_INSTANCE>(
+      env, charsequence_class.obj(), "toString", "()Ljava/lang/String;");
 }
 
 std::string ClipboardMap::Get(const std::string& format) {
   base::AutoLock lock(lock_);
   SyncWithAndroidClipboard();
   std::map<std::string, std::string>::const_iterator it = map_.find(format);
   return it == map_.end() ? std::string() : it->second;
 }
 
 bool ClipboardMap::HasFormat(const std::string& format) {
@@ skipping 284 matching lines @@
   packed += std::string(pixel_data, bm_size);
   g_map.Get().Set(kBitmapFormat, packed);
 }
 
 void Clipboard::WriteData(const Clipboard::FormatType& format,
                           const char* data_data, size_t data_len) {
   g_map.Get().Set(format.data(), std::string(data_data, data_len));
 }
 
 } // namespace ui