Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Side by Side Diff: content/browser/android/download_controller.cc

Issue 11038015: Android: lazy initialization for method id. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removes EXCEPTIONCHECK. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/android/download_controller.h" 5 #include "content/browser/android/download_controller.h"
6 6
7 #include "base/android/jni_android.h" 7 #include "base/android/jni_android.h"
8 #include "base/android/jni_string.h" 8 #include "base/android/jni_string.h"
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 11 matching lines...) Expand all
22 #include "net/cookies/cookie_options.h" 22 #include "net/cookies/cookie_options.h"
23 #include "net/cookies/cookie_store.h" 23 #include "net/cookies/cookie_store.h"
24 #include "net/http/http_request_headers.h" 24 #include "net/http/http_request_headers.h"
25 #include "net/url_request/url_request.h" 25 #include "net/url_request/url_request.h"
26 #include "net/url_request/url_request_context.h" 26 #include "net/url_request/url_request_context.h"
27 27
28 using base::android::AttachCurrentThread; 28 using base::android::AttachCurrentThread;
29 using base::android::CheckException; 29 using base::android::CheckException;
30 using base::android::ConvertUTF8ToJavaString; 30 using base::android::ConvertUTF8ToJavaString;
31 using base::android::GetClass; 31 using base::android::GetClass;
32 using base::android::MethodID;
32 using base::android::ScopedJavaLocalRef; 33 using base::android::ScopedJavaLocalRef;
33 34
34 namespace { 35 namespace {
35 const char kDownloadControllerClassPathName[] = 36 const char kDownloadControllerClassPathName[] =
36 "org/chromium/content/browser/DownloadController"; 37 "org/chromium/content/browser/DownloadController";
37 } // namespace 38 } // namespace
38 39
39 namespace content { 40 namespace content {
40 41
41 // JNI methods 42 // JNI methods
(...skipping 252 matching lines...) Expand 10 before | Expand all | Expand 10 after
294 } 295 }
295 296
296 DownloadController::JavaObject* DownloadController::GetJavaObject() { 297 DownloadController::JavaObject* DownloadController::GetJavaObject() {
297 if (!java_object_) { 298 if (!java_object_) {
298 // Initialize Java DownloadController by calling 299 // Initialize Java DownloadController by calling
299 // DownloadController.getInstance(), which will call Init() 300 // DownloadController.getInstance(), which will call Init()
300 // if Java DownloadController is not instantiated already. 301 // if Java DownloadController is not instantiated already.
301 JNIEnv* env = AttachCurrentThread(); 302 JNIEnv* env = AttachCurrentThread();
302 ScopedJavaLocalRef<jclass> clazz = 303 ScopedJavaLocalRef<jclass> clazz =
303 GetClass(env, kDownloadControllerClassPathName); 304 GetClass(env, kDownloadControllerClassPathName);
304 jmethodID get_instance = GetStaticMethodID(env, clazz, "getInstance", 305 jmethodID get_instance = MethodID::Get<MethodID::METHODTYPE_NORMAL>(
306 env, clazz.obj(), "getInstance",
305 "()Lorg/chromium/content/browser/DownloadController;"); 307 "()Lorg/chromium/content/browser/DownloadController;");
306 ScopedJavaLocalRef<jobject> jobj(env, 308 ScopedJavaLocalRef<jobject> jobj(env,
307 env->CallStaticObjectMethod(clazz.obj(), get_instance)); 309 env->CallStaticObjectMethod(clazz.obj(), get_instance));
308 CheckException(env); 310 CheckException(env);
309 } 311 }
310 312
311 DCHECK(java_object_); 313 DCHECK(java_object_);
312 return java_object_; 314 return java_object_;
313 } 315 }
314 316
315 DownloadController::DownloadInfoAndroid::DownloadInfoAndroid( 317 DownloadController::DownloadInfoAndroid::DownloadInfoAndroid(
316 net::URLRequest* request) { 318 net::URLRequest* request) {
317 request->GetResponseHeaderByName("content-disposition", &content_disposition); 319 request->GetResponseHeaderByName("content-disposition", &content_disposition);
318 request->GetResponseHeaderByName("mime-type", &original_mime_type); 320 request->GetResponseHeaderByName("mime-type", &original_mime_type);
319 request->extra_request_headers().GetHeader( 321 request->extra_request_headers().GetHeader(
320 net::HttpRequestHeaders::kUserAgent, &user_agent); 322 net::HttpRequestHeaders::kUserAgent, &user_agent);
321 GURL referer_url(request->GetSanitizedReferrer()); 323 GURL referer_url(request->GetSanitizedReferrer());
322 if (referer_url.is_valid()) 324 if (referer_url.is_valid())
323 referer = referer_url.spec(); 325 referer = referer_url.spec();
324 if (!request->url_chain().empty()) { 326 if (!request->url_chain().empty()) {
325 original_url = request->url_chain().front(); 327 original_url = request->url_chain().front();
326 url = request->url_chain().back(); 328 url = request->url_chain().back();
327 } 329 }
328 } 330 }
329 331
330 DownloadController::DownloadInfoAndroid::~DownloadInfoAndroid() {} 332 DownloadController::DownloadInfoAndroid::~DownloadInfoAndroid() {}
331 333
332 } // namespace content 334 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698