chrome/browser/ui/webui/ntp/most_visited_handler.cc - Issue 11038014: [Android] Upstream remaining changes to NTP UI code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/ntp/most_visited_handler.cc

Issue 11038014: [Android] Upstream remaining changes to NTP UI code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/ntp/most_visited_handler.cc

diff --git a/chrome/browser/ui/webui/ntp/most_visited_handler.cc b/chrome/browser/ui/webui/ntp/most_visited_handler.cc

index 09be6313d80eadfeb5064832c68729f3e6abecbd..10bfbab143922171682449594c970a80b5f05185 100644

--- a/chrome/browser/ui/webui/ntp/most_visited_handler.cc

+++ b/chrome/browser/ui/webui/ntp/most_visited_handler.cc

@@ -74,6 +74,10 @@ void MostVisitedHandler::RegisterMessages() {

ThumbnailSource* thumbnail_src = new ThumbnailSource(profile);

ChromeURLDataManager::AddDataSource(profile, thumbnail_src);

+#if defined(OS_ANDROID)

+ ChromeURLDataManager::AddDataSource(profile,

+ new FaviconSource(profile, FaviconSource::ANY));

+#endif

ChromeURLDataManager::AddDataSource(profile,

new FaviconSource(profile, FaviconSource::FAVICON));

Evan Stade 2012/10/02 14:42:43 you need both of these on android?

newt (away) 2012/10/05 13:31:05 Yes. Added comments to explain. ANY is perhaps n