Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: src/assembler.h

Issue 11037023: Use movw/movt instead of constant pool on ARMv7 (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: More fixes and nit fixes Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 351 matching lines...) Expand 10 before | Expand all | Expand 10 after
362 362
363 private: 363 private:
364 // On ARM, note that pc_ is the address of the constant pool entry 364 // On ARM, note that pc_ is the address of the constant pool entry
365 // to be relocated and not the address of the instruction 365 // to be relocated and not the address of the instruction
366 // referencing the constant pool entry (except when rmode_ == 366 // referencing the constant pool entry (except when rmode_ ==
367 // comment). 367 // comment).
368 byte* pc_; 368 byte* pc_;
369 Mode rmode_; 369 Mode rmode_;
370 intptr_t data_; 370 intptr_t data_;
371 Code* host_; 371 Code* host_;
372 #ifdef V8_TARGET_ARCH_MIPS 372 // Code and Embedded Object pointers on some platforms are stored split
373 // Code and Embedded Object pointers in mips are stored split
374 // across two consecutive 32-bit instructions. Heap management 373 // across two consecutive 32-bit instructions. Heap management
375 // routines expect to access these pointers indirectly. The following 374 // routines expect to access these pointers indirectly. The following
376 // location provides a place for these pointers to exist natually 375 // location provides a place for these pointers to exist natually
Michael Starzinger 2012/10/10 14:19:29 s/natually/naturally/
danno 2012/10/17 10:04:44 Done.
377 // when accessed via the Iterator. 376 // when accessed via the Iterator.
378 Object* reconstructed_obj_ptr_; 377 Object* reconstructed_obj_ptr_;
379 // External-reference pointers are also split across instruction-pairs 378 // External-reference pointers are also split across instruction-pairs
380 // in mips, but are accessed via indirect pointers. This location 379 // on some platforms, but are accessed via indirect pointers. This location
381 // provides a place for that pointer to exist naturally. Its address 380 // provides a place for that pointer to exist naturally. Its address
382 // is returned by RelocInfo::target_reference_address(). 381 // is returned by RelocInfo::target_reference_address().
383 Address reconstructed_adr_ptr_; 382 Address reconstructed_adr_ptr_;
384 #endif // V8_TARGET_ARCH_MIPS
385 friend class RelocIterator; 383 friend class RelocIterator;
386 }; 384 };
387 385
388 386
389 // RelocInfoWriter serializes a stream of relocation info. It writes towards 387 // RelocInfoWriter serializes a stream of relocation info. It writes towards
390 // lower addresses. 388 // lower addresses.
391 class RelocInfoWriter BASE_EMBEDDED { 389 class RelocInfoWriter BASE_EMBEDDED {
392 public: 390 public:
393 RelocInfoWriter() : pos_(NULL), 391 RelocInfoWriter() : pos_(NULL),
394 last_pc_(NULL), 392 last_pc_(NULL),
(...skipping 495 matching lines...) Expand 10 before | Expand all | Expand 10 after
890 public: 888 public:
891 NullCallWrapper() { } 889 NullCallWrapper() { }
892 virtual ~NullCallWrapper() { } 890 virtual ~NullCallWrapper() { }
893 virtual void BeforeCall(int call_size) const { } 891 virtual void BeforeCall(int call_size) const { }
894 virtual void AfterCall() const { } 892 virtual void AfterCall() const { }
895 }; 893 };
896 894
897 } } // namespace v8::internal 895 } } // namespace v8::internal
898 896
899 #endif // V8_ASSEMBLER_H_ 897 #endif // V8_ASSEMBLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698