Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2110)

Unified Diff: content/renderer/browser_plugin/browser_plugin.h

Issue 11035067: Add loadCommit and loadStop Event (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix Comments Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/browser_plugin/browser_plugin.h
diff --git a/content/renderer/browser_plugin/browser_plugin.h b/content/renderer/browser_plugin/browser_plugin.h
index f646f3c241c3649da64441d4e0845de30888f403..2e866dbd4a27026d57c21b07a630cde1270b1961 100644
--- a/content/renderer/browser_plugin/browser_plugin.h
+++ b/content/renderer/browser_plugin/browser_plugin.h
@@ -18,7 +18,7 @@
#include "third_party/WebKit/Source/WebKit/chromium/public/WebDragStatus.h"
struct BrowserPluginHostMsg_ResizeGuest_Params;
-struct BrowserPluginMsg_DidNavigate_Params;
+struct BrowserPluginMsg_LoadCommit_Params;
struct BrowserPluginMsg_UpdateRect_Params;
namespace content {
@@ -58,10 +58,12 @@ class CONTENT_EXPORT BrowserPlugin :
const BrowserPluginMsg_UpdateRect_Params& params);
// Inform the BrowserPlugin that its guest has crashed.
void GuestCrashed();
- // Informs the BrowserPlugin that the guest has navigated to a new URL.
- void DidNavigate(const BrowserPluginMsg_DidNavigate_Params& params);
+ // Inform the BrowserPlugin that the guest has navigated to a new URL.
+ void LoadCommit(const BrowserPluginMsg_LoadCommit_Params& params);
// Inform the BrowserPlugin that the guest has started loading a new page.
void LoadStart(const GURL& url, bool is_top_level);
+ // Inform the BrowserPlugin that the guest has finished loading a new page.
+ void LoadStop();
// Inform the BrowserPlugin that the guest has aborted loading a new page.
void LoadAbort(const GURL& url, bool is_top_level, const std::string& type);
// Inform the BrowserPlugin that the guest has redirected a navigation.
@@ -71,7 +73,6 @@ class CONTENT_EXPORT BrowserPlugin :
// Tells the BrowserPlugin to advance the focus to the next (or previous)
// element.
void AdvanceFocus(bool reverse);
-
Charlie Reis 2012/10/16 21:17:55 Please leave this line, to avoid code churn.
irobert 2012/10/17 20:12:37 Done.
// Informs the BrowserPlugin that the guest has started/stopped accepting
// touch events.
void SetAcceptTouchEvents(bool accept);

Powered by Google App Engine
This is Rietveld 408576698