Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: content/browser/browser_plugin/browser_plugin_guest.cc

Issue 11035067: Add loadCommit and loadStop Event (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix Comments Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_plugin/browser_plugin_guest.cc
diff --git a/content/browser/browser_plugin/browser_plugin_guest.cc b/content/browser/browser_plugin/browser_plugin_guest.cc
index fda0c620e740c6020edaf010cbc09934de769a37..aa442ca7ea0bfe6e15b056fc9466a230f48a19f5 100644
--- a/content/browser/browser_plugin/browser_plugin_guest.cc
+++ b/content/browser/browser_plugin/browser_plugin_guest.cc
@@ -419,7 +419,7 @@ void BrowserPluginGuest::DidCommitProvisionalLoadForFrame(
PageTransition transition_type,
RenderViewHost* render_view_host) {
// Inform its embedder of the updated URL.
- BrowserPluginMsg_DidNavigate_Params params;
+ BrowserPluginMsg_LoadCommit_Params params;
params.url = url;
params.is_top_level = is_main_frame;
params.process_id = render_view_host->GetProcess()->GetID();
@@ -428,8 +428,13 @@ void BrowserPluginGuest::DidCommitProvisionalLoadForFrame(
params.entry_count =
web_contents()->GetController().GetEntryCount();
SendMessageToEmbedder(
- new BrowserPluginMsg_DidNavigate(instance_id(), params));
- RecordAction(UserMetricsAction("BrowserPlugin.Guest.DidNavigate"));
+ new BrowserPluginMsg_LoadCommit(instance_id(), params));
+ RecordAction(UserMetricsAction("BrowserPlugin.Guest.DidCommit"));
Charlie Reis 2012/10/16 21:17:55 As before, please leave this as BrowserPlugin.Gues
irobert 2012/10/17 20:12:37 Done.
+}
+
+void BrowserPluginGuest::DidStopLoading(RenderViewHost* render_view_host) {
+ SendMessageToEmbedder(
+ new BrowserPluginMsg_LoadStop(instance_id()));
Charlie Reis 2012/10/16 21:17:55 This will all fit on one line.
irobert 2012/10/17 20:12:37 Done.
}
void BrowserPluginGuest::RenderViewGone(base::TerminationStatus status) {

Powered by Google App Engine
This is Rietveld 408576698