Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: content/common/browser_plugin_messages.h

Issue 11035067: Add loadCommit and loadStop Event (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix DidNavigate Struct and Test Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/browser_plugin_messages.h
diff --git a/content/common/browser_plugin_messages.h b/content/common/browser_plugin_messages.h
index 69de1ee9c191ae663cd3547a57cbb0431514c54b..370fff4c7cd1406bd5ef44a08ce3e9ef420791f6 100644
--- a/content/common/browser_plugin_messages.h
+++ b/content/common/browser_plugin_messages.h
@@ -174,7 +174,7 @@ IPC_MESSAGE_CONTROL4(BrowserPluginMsg_LoadRedirect,
GURL /* new_url */,
bool /* is_top_level */)
-IPC_STRUCT_BEGIN(BrowserPluginMsg_DidNavigate_Params)
+IPC_STRUCT_BEGIN(BrowserPluginMsg_LoadCommit_Params)
// The current URL of the guest.
IPC_STRUCT_MEMBER(GURL, url)
// Indicates whether the navigation was on the top-level frame.
@@ -188,12 +188,16 @@ IPC_STRUCT_BEGIN(BrowserPluginMsg_DidNavigate_Params)
IPC_STRUCT_MEMBER(int, entry_count)
IPC_STRUCT_END()
-// When the guest navigates, the browser process informs the embedder through
-// the BrowserPluginMsg_DidNavigate message along with information about the
-// guest's current navigation state.
-IPC_MESSAGE_CONTROL2(BrowserPluginMsg_DidNavigate,
+// When all the guest pages have completed, the browser process informs
Fady Samuel 2012/10/16 01:40:00 I don't think this comment is accurate. "When th
irobert 2012/10/16 20:10:09 Done.
+// the embedder through the BrowserPluginMsg_DidCommit message.
+IPC_MESSAGE_CONTROL2(BrowserPluginMsg_LoadCommit,
int /* instance_id */,
- BrowserPluginMsg_DidNavigate_Params)
+ BrowserPluginMsg_LoadCommit_Params)
+
+// When the guest navigates, the browser process informs the embedder through
+// the BrowserPluginMsg_LoadStop message.
+IPC_MESSAGE_CONTROL1(BrowserPluginMsg_LoadStop,
+ int /* instance_id */)
// When the guest crashes, the browser process informs the embedder through this
// message.

Powered by Google App Engine
This is Rietveld 408576698