Add loadCommit and loadStop Event

content/test/data/browser_plugin_embedder.html

Index: content/test/data/browser_plugin_embedder.html
diff --git a/content/test/data/browser_plugin_embedder.html b/content/test/data/browser_plugin_embedder.html
index 45b374e3ac9f9d91494114f5cfb0b6418c9a0168..18751834593523b3367fa25c2b69fa65186fb6dc 100644
--- a/content/test/data/browser_plugin_embedder.html
+++ b/content/test/data/browser_plugin_embedder.html
@@ -5,6 +5,16 @@ function loadAbort(evt) {
 function loadStart(evt) {
   document.title = evt.url;
 }
+function loadStop(evt) {
+  document.title = "loadStop";
+}
+
+var isTopLevel;

[Charlie Reis, 2012/10/11 18:55:28]

nit: commitIsTopLevel.
(There are isTopLevel properties on other events as well.)

[irobert, 2012/10/11 20:45:49]

Done.

+function loadCommit(evt) {
+    document.title = evt.url;

[Charlie Reis, 2012/10/11 18:55:28]

We can't distinguish between this and loadStart.  Both set the title to the URL.

That means your test might be flaky: if the title watcher hears loadStart and
looks for isTopLevel before loadCommit happens, then it will fail.  (You may
still see it pass in some cases if the title watcher doesn't get a chance to
react before both loadStart and loadCommit have fired.)

Since title watchers wait for a particular title to show up, it might be
possible to have each event update the title with a unique string.  If you set
it to "loadCommit" instead, we could wait for that reliably.

[irobert, 2012/10/11 20:45:49]

I use "loadCommit:" as the prefix and plus the url as the title changed by
loadCommit event handler.

On 2012/10/11 18:55:28, creis wrote:

+    isTopLevel = evt.isTopLevel;
+}
+
 var redirectOldUrl;
 var redirectNewUrl;
 function loadRedirect(event) {
@@ -53,4 +63,6 @@ document.title = 'embedder';
   plugin.addEventListener('loadStart', loadStart);
   plugin.addEventListener('loadAbort', loadAbort);
   plugin.addEventListener('loadRedirect', loadRedirect);
+  plugin.addEventListener('loadStop', loadStop);
+  plugin.addEventListener('loadCommit', loadCommit);
 </script>