Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1337)

Unified Diff: content/renderer/browser_plugin/browser_plugin.h

Issue 11035067: Add loadCommit and loadStop Event (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix Comments and Nits Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/browser_plugin/browser_plugin.h
diff --git a/content/renderer/browser_plugin/browser_plugin.h b/content/renderer/browser_plugin/browser_plugin.h
index 45ae96d09a691c0183cc628fcfa455306bd19031..d10447f1a5b83d321eee3500a55b533f5dd9348c 100644
--- a/content/renderer/browser_plugin/browser_plugin.h
+++ b/content/renderer/browser_plugin/browser_plugin.h
@@ -52,8 +52,11 @@ class CONTENT_EXPORT BrowserPlugin :
const BrowserPluginMsg_UpdateRect_Params& params);
// Inform the BrowserPlugin that its guest has crashed.
void GuestCrashed();
- // Informs the BrowserPlugin that the guest has navigated to a new URL.
- void DidNavigate(const GURL& url, int process_id);
+
+ // Inform the BrowserPlugin that the guest has finished loading a new page.
+ void LoadStop();
Charlie Reis 2012/10/11 18:55:28 nit: We probably should re-order these closer to h
irobert 2012/10/11 20:45:49 Done.
+ // Inform the BrowserPlugin that the guest has navigated to a new URL.
+ void LoadCommit(const GURL& url, int process_id, bool is_top_level);
// Inform the BrowserPlugin that the guest has started loading a new page.
void LoadStart(const GURL& url, bool is_top_level);
// Inform the BrowserPlugin that the guest has aborted loading a new page.

Powered by Google App Engine
This is Rietveld 408576698