Add loadCommit and loadStop Event

content/renderer/browser_plugin/browser_plugin.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef  CONTENT_RENDERER_BROWSER_PLUGIN_BROWSER_PLUGIN_H_
 #define  CONTENT_RENDERER_BROWSER_PLUGIN_BROWSER_PLUGIN_H_
 
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebPlugin.h"
 
 #include "base/memory/scoped_ptr.h"
@@ skipping 34 matching lines @@
   // set appropriately to indicate the failure reason.
   bool SetPartitionAttribute(const std::string& partition_id,
                              std::string& error_message);
 
   // Inform the BrowserPlugin to update its backing store with the pixels in
   // its damage buffer.
   void UpdateRect(int message_id,
                   const BrowserPluginMsg_UpdateRect_Params& params);
   // Inform the BrowserPlugin that its guest has crashed.
   void GuestCrashed();
-  // Informs the BrowserPlugin that the guest has navigated to a new URL.
-  void DidNavigate(const GURL& url, int process_id);
+
+  // Inform the BrowserPlugin that the guest has finished loading a new page.
+  void LoadStop();
+  // Inform the BrowserPlugin that the guest has navigated to a new URL.
+  void LoadCommit(const GURL& url, int process_id, bool is_top_level);

[Fady Samuel, 2012/10/11 15:25:36]

FYI, this conflicts with my patch http://codereview.chromium.org/11092023/.
Depending on which one of us lands first, one of us will have to do a little bit
of rebasing. :-)

[irobert, 2012/10/11 16:50:44]

Sure. Since we are planning to remove this DidNavigate API, and I have already
replace the code which call this API with the LoadCommit API. I think you can
land first and I can rebase based on your commit. 

I don't know whether it is ok or not. 

On 2012/10/11 15:25:36, Fady Samuel wrote:

   // Inform the BrowserPlugin that the guest has started loading a new page.
   void LoadStart(const GURL& url, bool is_top_level);
   // Inform the BrowserPlugin that the guest has aborted loading a new page.
   void LoadAbort(const GURL& url, bool is_top_level, const std::string& type);
   // Inform the BrowserPlugin that the guest has redirected a navigation.
   void LoadRedirect(const GURL& old_url,
                     const GURL& new_url,
                     bool is_top_level);
   // Tells the BrowserPlugin to advance the focus to the next (or previous)
   // element.
@@ skipping 132 matching lines @@
   EventListenerMap event_listener_map_;
 #if defined(OS_WIN)
   base::SharedMemory shared_memory_;
 #endif
   DISALLOW_COPY_AND_ASSIGN(BrowserPlugin);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_BROWSER_PLUGIN_BROWSER_PLUGIN_H_