Mac Web Intents Part 15: Inline extension install prompt (model)

chrome/browser/extensions/extension_install_prompt.h

Index: chrome/browser/extensions/extension_install_prompt.h
diff --git a/chrome/browser/extensions/extension_install_prompt.h b/chrome/browser/extensions/extension_install_prompt.h
index 1b65fa66e69dde2441baf2f9a487630102c3a587..4ba4428d4c2e8adea65537cc0813a4d6a59fe762 100644
--- a/chrome/browser/extensions/extension_install_prompt.h
+++ b/chrome/browser/extensions/extension_install_prompt.h
@@ -8,6 +8,7 @@
 #include <string>
 #include <vector>
 
+#include "base/callback.h"
 #include "base/compiler_specific.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/string16.h"
@@ -157,6 +158,12 @@ class ExtensionInstallPrompt : public ImageLoadingTracker::Observer,
     virtual ~Delegate() {}
   };
 
+  typedef base::Callback<void(gfx::NativeWindow,
+                              content::PageNavigator*,
+                              ExtensionInstallPrompt::Delegate*,
+                              const ExtensionInstallPrompt::Prompt&)>
+      ShowDialogCallback;
+
   // Creates a dummy extension from the |manifest|, replacing the name and
   // description with the localizations if provided.
   static scoped_refptr<extensions::Extension> GetLocalizedExtensionForDisplay(
@@ -207,8 +214,10 @@ class ExtensionInstallPrompt : public ImageLoadingTracker::Observer,
   // proceed. This is declared virtual for testing.
   //
   // We *MUST* eventually call either Proceed() or Abort() on |delegate|.

[Greg Billock, 2012/10/03 17:20:35]

Can you comment this as well where the web intents picker gets the prompt, so
the responsibility is documented there?

[sail, 2012/10/03 20:24:29]

Done.
Added comment to WebIntentPicker::OnShowExtensionInstallDialog().

-  virtual void ConfirmInstall(Delegate* delegate,
-                              const extensions::Extension* extension);
+  virtual void ConfirmInstall(
+      Delegate* delegate,
+      const extensions::Extension* extension,
+      const ShowDialogCallback& show_dialog_callback);
 
   // This is called by the app handler launcher to verify whether the app
   // should be re-enabled. This is declared virtual for testing.
@@ -311,6 +320,8 @@ class ExtensionInstallPrompt : public ImageLoadingTracker::Observer,
   // Keeps track of extension images being loaded on the File thread for the
   // purpose of showing the install UI.
   ImageLoadingTracker tracker_;
+
+  ShowDialogCallback show_dialog_callback_;
 };
 
 namespace chrome {