Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 11034027: cros: Preload external extension icons. (Closed)

Created:
8 years, 2 months ago by xiyuan
Modified:
8 years, 2 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, Marijn Kruisselbrink
Visibility:
Public.

Description

cros: Preload external extension icons. Preload external extensions (aka default apps) icons so that they are available when adding to launcher. This improves user experience on first time signing into a ChromeOS device where external extension installation might stall the icon loading and causing long delay before proper icon showing up. BUG=146114 TEST=Verify app icons show up without delay on launcher bar. R=aa@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -0 lines) Patch
M chrome/browser/extensions/crx_installer.h View 4 chunks +17 lines, -0 lines 0 comments Download
M chrome/browser/extensions/crx_installer.cc View 4 chunks +50 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
xiyuan
8 years, 2 months ago (2012-10-02 16:25:16 UTC) #1
xiyuan
+mek
8 years, 2 months ago (2012-10-05 18:33:35 UTC) #2
Aaron Boodman
How does it work in the normal startup case? (Why is it faster then?)
8 years, 2 months ago (2012-10-08 02:23:51 UTC) #3
xiyuan
On 2012/10/08 02:23:51, Aaron Boodman wrote: > How does it work in the normal startup ...
8 years, 2 months ago (2012-10-08 16:55:40 UTC) #4
Aaron Boodman
Should I still be reviewing this, or has it been abandoned?
8 years, 2 months ago (2012-10-24 22:06:40 UTC) #5
xiyuan
8 years, 2 months ago (2012-10-24 22:10:43 UTC) #6
On 2012/10/24 22:06:40, Aaron Boodman wrote:
> Should I still be reviewing this, or has it been abandoned?

Let me close this. It seems moving to blocking pool solves most of the problem
for 146114. (I have not yet able to verify the bug on arm device yet and will
close the bug once I get my hand on such a device.)

Powered by Google App Engine
This is Rietveld 408576698