Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 11031026: Remove RootWindow reference from DragDropTracker. RootWindow reference in (Closed)

Created:
8 years, 2 months ago by varunjain
Modified:
8 years, 2 months ago
Reviewers:
mazda, sky
CC:
chromium-reviews, sadrul, dcheng, ben+watch_chromium.org
Visibility:
Public.

Description

Remove RootWindow reference from DragDropTracker. RootWindow reference in DragDropTracker seems unnecessary. After this change, the capture_window will be parented to the currently active RootWindow which seems fine. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=160457

Patch Set 1 #

Total comments: 4

Patch Set 2 : patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -40 lines) Patch
M ash/drag_drop/drag_drop_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/drag_drop/drag_drop_tracker.h View 1 2 chunks +5 lines, -6 lines 0 comments Download
M ash/drag_drop/drag_drop_tracker.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M ash/drag_drop/drag_drop_tracker_unittest.cc View 6 chunks +33 lines, -27 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
varunjain
8 years, 2 months ago (2012-10-04 21:46:09 UTC) #1
mazda
lgtm with nits Thank you for the clean up. http://codereview.chromium.org/11031026/diff/1/ash/drag_drop/drag_drop_tracker.h File ash/drag_drop/drag_drop_tracker.h (left): http://codereview.chromium.org/11031026/diff/1/ash/drag_drop/drag_drop_tracker.h#oldcode31 ash/drag_drop/drag_drop_tracker.h:31: ...
8 years, 2 months ago (2012-10-04 21:54:33 UTC) #2
varunjain
http://codereview.chromium.org/11031026/diff/1/ash/drag_drop/drag_drop_tracker.h File ash/drag_drop/drag_drop_tracker.h (left): http://codereview.chromium.org/11031026/diff/1/ash/drag_drop/drag_drop_tracker.h#oldcode31 ash/drag_drop/drag_drop_tracker.h:31: // Gets the target located at |event| in the ...
8 years, 2 months ago (2012-10-05 16:07:00 UTC) #3
varunjain
+sky for OWNERS
8 years, 2 months ago (2012-10-05 16:07:28 UTC) #4
sky
LGTM
8 years, 2 months ago (2012-10-05 16:48:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varunjain@chromium.org/11031026/4001
8 years, 2 months ago (2012-10-05 16:50:58 UTC) #6
commit-bot: I haz the power
8 years, 2 months ago (2012-10-05 19:51:08 UTC) #7
Change committed as 160457

Powered by Google App Engine
This is Rietveld 408576698