Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: ash/display/display_controller_unittest.cc

Issue 11030017: Add context to gfx::Screen calls in support of simultaneous desktop+ash (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix other os's Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/display/display_controller_unittest.cc
diff --git a/ash/display/display_controller_unittest.cc b/ash/display/display_controller_unittest.cc
index 97d7707730fb5131bf5925460bba13e4cbe61d1a..a88fd95c80827b51ecdf87195ca0071fc3817baf 100644
--- a/ash/display/display_controller_unittest.cc
+++ b/ash/display/display_controller_unittest.cc
@@ -146,11 +146,11 @@ TEST_F(DisplayControllerTest, MAYBE_BoundsUpdated) {
UpdateDisplay("400x400");
EXPECT_EQ(1, observer.CountAndReset());
EXPECT_EQ("0,0 400x400", GetPrimaryDisplay().bounds().ToString());
- EXPECT_EQ(1, gfx::Screen::GetNumDisplays());
+ EXPECT_EQ(1, gfx::Screen::GetNumDisplays(ash::Shell::GetRootNativeView()));
UpdateDisplay("500x500,700x700");
EXPECT_EQ(2, observer.CountAndReset());
- ASSERT_EQ(2, gfx::Screen::GetNumDisplays());
+ ASSERT_EQ(2, gfx::Screen::GetNumDisplays(ash::Shell::GetRootNativeView()));
EXPECT_EQ("0,0 500x500", GetPrimaryDisplay().bounds().ToString());
EXPECT_EQ("0,500 700x700", GetSecondaryDisplay().bounds().ToString());
}
@@ -190,7 +190,8 @@ TEST_F(DisplayControllerTest, SwapPrimary) {
Shell::GetInstance()->display_controller();
UpdateDisplay("200x200,300x300");
- gfx::Display primary_display = gfx::Screen::GetPrimaryDisplay();
+ gfx::Display primary_display = gfx::Screen::GetPrimaryDisplay(
+ ash::Shell::GetRootNativeView());
gfx::Display secondary_display = ScreenAsh::GetSecondaryDisplay();
std::string secondary_name = aura::Env::GetInstance()->
@@ -209,7 +210,8 @@ TEST_F(DisplayControllerTest, SwapPrimary) {
EXPECT_TRUE(primary_root->Contains(launcher_window));
EXPECT_FALSE(secondary_root->Contains(launcher_window));
EXPECT_EQ(primary_display.id(),
- gfx::Screen::GetDisplayNearestPoint(gfx::Point(-100, -100)).id());
+ gfx::Screen::GetDisplayNearestPoint(
+ ash::Shell::GetRootNativeView(), gfx::Point(-100, -100)).id());
EXPECT_EQ(primary_display.id(),
gfx::Screen::GetDisplayNearestWindow(NULL).id());
@@ -218,7 +220,8 @@ TEST_F(DisplayControllerTest, SwapPrimary) {
EXPECT_EQ(secondary_display.id(), gfx::Screen::GetPrimaryDisplay().id());
EXPECT_EQ(primary_display.id(), ScreenAsh::GetSecondaryDisplay().id());
EXPECT_EQ(secondary_display.id(),
- gfx::Screen::GetDisplayNearestPoint(gfx::Point(-100, -100)).id());
+ gfx::Screen::GetDisplayNearestPoint(
+ ash::Shell::GetRootNativeView(), gfx::Point(-100, -100)).id());
EXPECT_EQ(secondary_display.id(),
gfx::Screen::GetDisplayNearestWindow(NULL).id());
@@ -243,10 +246,11 @@ TEST_F(DisplayControllerTest, SwapPrimary) {
// Deleting 2nd display should move the primary to original primary display.
UpdateDisplay("200x200");
RunAllPendingInMessageLoop(); // RootWindow is deleted in a posted task.
- EXPECT_EQ(1, gfx::Screen::GetNumDisplays());
+ EXPECT_EQ(1, gfx::Screen::GetNumDisplays(ash::Shell::GetRootNativeView()));
EXPECT_EQ(primary_display.id(), gfx::Screen::GetPrimaryDisplay().id());
EXPECT_EQ(primary_display.id(),
- gfx::Screen::GetDisplayNearestPoint(gfx::Point(-100, -100)).id());
+ gfx::Screen::GetDisplayNearestPoint(
+ ash::Shell::GetRootNativeView(), gfx::Point(-100, -100)).id());
EXPECT_EQ(primary_display.id(),
gfx::Screen::GetDisplayNearestWindow(NULL).id());
EXPECT_TRUE(tracker.Contains(primary_root));
@@ -256,7 +260,7 @@ TEST_F(DisplayControllerTest, SwapPrimary) {
TEST_F(DisplayControllerTest, MAYBE_UpdateDisplayWithHostOrigin) {
UpdateDisplay("100x200,300x400");
- ASSERT_EQ(2, gfx::Screen::GetNumDisplays());
+ ASSERT_EQ(2, gfx::Screen::GetNumDisplays(ash::Shell::GetRootNativeView()));
Shell::RootWindowList root_windows =
Shell::GetInstance()->GetAllRootWindows();
ASSERT_EQ(2U, root_windows.size());
@@ -267,21 +271,21 @@ TEST_F(DisplayControllerTest, MAYBE_UpdateDisplayWithHostOrigin) {
EXPECT_EQ("300x400", root_windows[1]->GetHostSize().ToString());
UpdateDisplay("100x200,200+300-300x400");
- ASSERT_EQ(2, gfx::Screen::GetNumDisplays());
+ ASSERT_EQ(2, gfx::Screen::GetNumDisplays(ash::Shell::GetRootNativeView()));
EXPECT_EQ("0,0", root_windows[0]->GetHostOrigin().ToString());
EXPECT_EQ("100x200", root_windows[0]->GetHostSize().ToString());
EXPECT_EQ("200,300", root_windows[1]->GetHostOrigin().ToString());
EXPECT_EQ("300x400", root_windows[1]->GetHostSize().ToString());
UpdateDisplay("400+500-200x300,300x400");
- ASSERT_EQ(2, gfx::Screen::GetNumDisplays());
+ ASSERT_EQ(2, gfx::Screen::GetNumDisplays(ash::Shell::GetRootNativeView()));
EXPECT_EQ("400,500", root_windows[0]->GetHostOrigin().ToString());
EXPECT_EQ("200x300", root_windows[0]->GetHostSize().ToString());
EXPECT_EQ("0,0", root_windows[1]->GetHostOrigin().ToString());
EXPECT_EQ("300x400", root_windows[1]->GetHostSize().ToString());
UpdateDisplay("100+200-100x200,300+500-200x300");
- ASSERT_EQ(2, gfx::Screen::GetNumDisplays());
+ ASSERT_EQ(2, gfx::Screen::GetNumDisplays(ash::Shell::GetRootNativeView()));
EXPECT_EQ("100,200", root_windows[0]->GetHostOrigin().ToString());
EXPECT_EQ("100x200", root_windows[0]->GetHostSize().ToString());
EXPECT_EQ("300,500", root_windows[1]->GetHostOrigin().ToString());

Powered by Google App Engine
This is Rietveld 408576698