Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Side by Side Diff: chrome/browser/ui/ash/window_positioner.cc

Issue 11030017: Add context to gfx::Screen calls in support of simultaneous desktop+ash (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix some new gfx::Screen additions Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/ash/window_positioner.h" 5 #include "chrome/browser/ui/ash/window_positioner.h"
6 6
7 #include "ash/shell.h" 7 #include "ash/shell.h"
8 #include "ash/wm/window_cycle_controller.h" 8 #include "ash/wm/window_cycle_controller.h"
9 #include "ash/wm/window_resizer.h" 9 #include "ash/wm/window_resizer.h"
10 #include "ash/wm/window_util.h" 10 #include "ash/wm/window_util.h"
(...skipping 29 matching lines...) Expand all
40 // was not yet initialized. 40 // was not yet initialized.
41 last_popup_position_x_ = popup_position_offset_from_screen_corner_x; 41 last_popup_position_x_ = popup_position_offset_from_screen_corner_x;
42 last_popup_position_y_ = popup_position_offset_from_screen_corner_y; 42 last_popup_position_y_ = popup_position_offset_from_screen_corner_y;
43 } 43 }
44 pop_position_offset_increment_x = grid; 44 pop_position_offset_increment_x = grid;
45 pop_position_offset_increment_y = grid; 45 pop_position_offset_increment_y = grid;
46 // We handle the Multi monitor support by retrieving the active window's 46 // We handle the Multi monitor support by retrieving the active window's
47 // work area. 47 // work area.
48 aura::Window* window = ash::wm::GetActiveWindow(); 48 aura::Window* window = ash::wm::GetActiveWindow();
49 const gfx::Rect work_area = window && window->IsVisible() ? 49 const gfx::Rect work_area = window && window->IsVisible() ?
50 gfx::Screen::GetDisplayNearestWindow(window).work_area() : 50 Shell::GetAshScreen()->GetDisplayNearestWindow(window).work_area() :
51 gfx::Screen::GetPrimaryDisplay().work_area(); 51 Shell::GetAshScreen()->GetPrimaryDisplay().work_area();
52 // Only try to reposition the popup when it is not spanning the entire 52 // Only try to reposition the popup when it is not spanning the entire
53 // screen. 53 // screen.
54 if ((old_pos.width() + popup_position_offset_from_screen_corner_x >= 54 if ((old_pos.width() + popup_position_offset_from_screen_corner_x >=
55 work_area.width()) || 55 work_area.width()) ||
56 (old_pos.height() + popup_position_offset_from_screen_corner_y >= 56 (old_pos.height() + popup_position_offset_from_screen_corner_y >=
57 work_area.height())) 57 work_area.height()))
58 return AlignPopupPosition(old_pos, work_area, grid); 58 return AlignPopupPosition(old_pos, work_area, grid);
59 const gfx::Rect result = SmartPopupPosition(old_pos, work_area, grid); 59 const gfx::Rect result = SmartPopupPosition(old_pos, work_area, grid);
60 if (!result.IsEmpty()) 60 if (!result.IsEmpty())
61 return AlignPopupPosition(result, work_area, grid); 61 return AlignPopupPosition(result, work_area, grid);
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
178 // If the alignment was pushing the window out of the screen, we ignore the 178 // If the alignment was pushing the window out of the screen, we ignore the
179 // alignment for that call. 179 // alignment for that call.
180 if (abs(pos.right() - work_area.right()) < grid) 180 if (abs(pos.right() - work_area.right()) < grid)
181 x = work_area.right() - w; 181 x = work_area.right() - w;
182 if (abs(pos.bottom() - work_area.bottom()) < grid) 182 if (abs(pos.bottom() - work_area.bottom()) < grid)
183 y = work_area.bottom() - h; 183 y = work_area.bottom() - h;
184 return gfx::Rect(x, y, w, h); 184 return gfx::Rect(x, y, w, h);
185 } 185 }
186 186
187 } // namespace ash 187 } // namespace ash
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698