Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: chrome/browser/plugins/plugin_observer.cc

Issue 11029045: Fix crash when a download is requested for an outdated plugin. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/plugins/plugin_observer.cc
diff --git a/chrome/browser/plugins/plugin_observer.cc b/chrome/browser/plugins/plugin_observer.cc
index 28637c2fb0c1c5d88f939b91b07c0e3a4912c78e..3bbc9ca7d857049e1307d26a52b7dde60c49d9c6 100644
--- a/chrome/browser/plugins/plugin_observer.cc
+++ b/chrome/browser/plugins/plugin_observer.cc
@@ -103,8 +103,7 @@ string16 ConfirmInstallDialogDelegate::GetAcceptButtonTitle() {
}
void ConfirmInstallDialogDelegate::OnAccepted() {
- installer()->StartInstalling(plugin_metadata_->url_for_display(),
- plugin_metadata_->plugin_url(),
+ installer()->StartInstalling(plugin_metadata_->plugin_url(),
TabContents::FromWebContents(web_contents_));
}
@@ -310,9 +309,7 @@ void PluginObserver::InstallMissingPlugin(
PluginInstaller* installer,
scoped_ptr<PluginMetadata> plugin_metadata) {
if (plugin_metadata->url_for_display()) {
- installer->OpenDownloadURL(plugin_metadata->url_for_display(),
- plugin_metadata->plugin_url(),
- web_contents());
+ installer->OpenDownloadURL(plugin_metadata->plugin_url(), web_contents());
} else {
TabModalConfirmDialog::Create(
new ConfirmInstallDialogDelegate(
« chrome/browser/plugins/plugin_installer.cc ('K') | « chrome/browser/plugins/plugin_installer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698