Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5323)

Unified Diff: chrome/browser/plugins/plugin_installer.h

Issue 11029045: Fix crash when a download is requested for an outdated plugin. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/plugins/plugin_installer.h
diff --git a/chrome/browser/plugins/plugin_installer.h b/chrome/browser/plugins/plugin_installer.h
index 8dca3fd7c29d53d4181a83c21a1c850c479993a7..5c6a25437ac0036a07129086f2def99e0b497c2d 100644
--- a/chrome/browser/plugins/plugin_installer.h
+++ b/chrome/browser/plugins/plugin_installer.h
@@ -48,17 +48,13 @@ class PluginInstaller : public content::DownloadItem::Observer {
InstallerState state() const { return state_; }
- // Opens the download URL in a new tab. This method should only be called if
- // |url_for_display| returns true.
- void OpenDownloadURL(bool url_for_display,
- const GURL& plugin_url,
+ // Opens the download URL in a new tab.
+ void OpenDownloadURL(GURL plugin_url,
content::WebContents* web_contents);
// Starts downloading the download URL and opens the downloaded file
- // when finished. This method should only be called if |url_for_display|
- // returns false.
- void StartInstalling(bool url_for_display,
- const GURL& plugin_url,
+ // when finished.
+ void StartInstalling(GURL plugin_url,
TabContents* tab_contents);
private:

Powered by Google App Engine
This is Rietveld 408576698