Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1069)

Unified Diff: chrome/browser/download/download_browsertest.cc

Issue 11028131: Shift passage of FileStream in downloads system to be by scoped_ptr<>. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed various try bot problems. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/api/downloads/downloads_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/download_browsertest.cc
diff --git a/chrome/browser/download/download_browsertest.cc b/chrome/browser/download/download_browsertest.cc
index 63904590ccdb0380970bf86fed24226491a919b5..6adeb6ea80ada909e3f623db1c6c556345d3f1f2 100644
--- a/chrome/browser/download/download_browsertest.cc
+++ b/chrome/browser/download/download_browsertest.cc
@@ -655,15 +655,17 @@ class DownloadTest : public InProcessBrowserTest {
if (download_info.download_method == DOWNLOAD_DIRECT) {
// Go directly to download. Don't wait for navigation.
- content::DownloadSaveInfo save_info;
+ scoped_ptr<content::DownloadSaveInfo> save_info(
+ new content::DownloadSaveInfo());
// NOTE: |prompt_for_save_location| may change during the download.
- save_info.prompt_for_save_location = false;
+ save_info->prompt_for_save_location = false;
scoped_refptr<content::DownloadTestItemCreationObserver>
creation_observer(new content::DownloadTestItemCreationObserver);
scoped_ptr<DownloadUrlParameters> params(
- DownloadUrlParameters::FromWebContents(web_contents, url, save_info));
+ DownloadUrlParameters::FromWebContents(
+ web_contents, url, save_info.Pass()));
params->set_callback(creation_observer->callback());
DownloadManagerForBrowser(browser())->DownloadUrl(params.Pass());
@@ -1732,10 +1734,12 @@ IN_PROC_BROWSER_TEST_F(DownloadTest, DownloadUrl) {
new content::DownloadTestObserverTerminal(
DownloadManagerForBrowser(browser()), 1,
content::DownloadTestObserver::ON_DANGEROUS_DOWNLOAD_FAIL));
- content::DownloadSaveInfo save_info;
- save_info.prompt_for_save_location = true;
+ scoped_ptr<content::DownloadSaveInfo> save_info(
+ new content::DownloadSaveInfo());
+ save_info->prompt_for_save_location = true;
scoped_ptr<DownloadUrlParameters> params(
- DownloadUrlParameters::FromWebContents(web_contents, url, save_info));
+ DownloadUrlParameters::FromWebContents(
+ web_contents, url, save_info.Pass()));
DownloadManagerForBrowser(browser())->DownloadUrl(params.Pass());
observer->WaitForFinished();
EXPECT_EQ(1u, observer->NumDownloadsSeenInState(DownloadItem::COMPLETE));
@@ -1759,12 +1763,14 @@ IN_PROC_BROWSER_TEST_F(DownloadTest, DownloadUrlToPath) {
ASSERT_TRUE(other_directory.CreateUniqueTempDir());
FilePath target_file_full_path
= other_directory.path().Append(file.BaseName());
- content::DownloadSaveInfo save_info;
- save_info.file_path = target_file_full_path;
+ scoped_ptr<content::DownloadSaveInfo> save_info(
+ new content::DownloadSaveInfo());
+ save_info->file_path = target_file_full_path;
content::DownloadTestObserver* observer(CreateWaiter(browser(), 1));
scoped_ptr<DownloadUrlParameters> params(
- DownloadUrlParameters::FromWebContents(web_contents, url, save_info));
+ DownloadUrlParameters::FromWebContents(
+ web_contents, url, save_info.Pass()));
DownloadManagerForBrowser(browser())->DownloadUrl(params.Pass());
observer->WaitForFinished();
EXPECT_EQ(1u, observer->NumDownloadsSeenInState(DownloadItem::COMPLETE));
@@ -2259,13 +2265,15 @@ IN_PROC_BROWSER_TEST_F(DownloadTest, HiddenDownload) {
download_manager,
1,
content::DownloadTestObserver::ON_DANGEROUS_DOWNLOAD_FAIL));
- content::DownloadSaveInfo save_info;
- save_info.prompt_for_save_location = false;
+ scoped_ptr<content::DownloadSaveInfo> save_info(
+ new content::DownloadSaveInfo());
+ save_info->prompt_for_save_location = false;
// Download and set IsHiddenDownload to true.
WebContents* web_contents = chrome::GetActiveWebContents(browser());
scoped_ptr<DownloadUrlParameters> params(
- DownloadUrlParameters::FromWebContents(web_contents, url, save_info));
+ DownloadUrlParameters::FromWebContents(
+ web_contents, url, save_info.Pass()));
params->set_callback(
base::Bind(&SetHiddenDownloadCallback, download_manager));
download_manager->DownloadUrl(params.Pass());
« no previous file with comments | « no previous file | chrome/browser/extensions/api/downloads/downloads_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698