content/browser/web_contents/web_contents_impl.cc - Issue 11028131: Shift passage of FileStream in downloads system to be by scoped_ptr<>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 11028131: Shift passage of FileStream in downloads system to be by scoped_ptr<>. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Incorporated Al's comments. Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/web_contents_impl.cc

diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc

index 6ef49c9c3de79d833482fb65f1a409846caedb08..01034b0f3e620c62ffa55483790cea9b24e2b930 100644

--- a/content/browser/web_contents/web_contents_impl.cc

+++ b/content/browser/web_contents/web_contents_impl.cc

@@ -3359,10 +3359,11 @@ void WebContentsImpl::SaveURL(const GURL& url,

if (entry)

post_id = entry->GetPostID();

}

- content::DownloadSaveInfo save_info;

- save_info.prompt_for_save_location = true;

+ scoped_ptr<content::DownloadSaveInfo> save_info(

+ new content::DownloadSaveInfo());

+ save_info->prompt_for_save_location = true;

scoped_ptr<DownloadUrlParameters> params(

- DownloadUrlParameters::FromWebContents(this, url, save_info));

+ DownloadUrlParameters::FromWebContents(this, url, save_info.Pass()));

params->set_referrer(referrer);

params->set_post_id(post_id);

params->set_prefer_cache(true);