content/browser/renderer_host/render_message_filter.cc - Issue 11028131: Shift passage of FileStream in downloads system to be by scoped_ptr<>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_message_filter.cc

Issue 11028131: Shift passage of FileStream in downloads system to be by scoped_ptr<>. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Incorporated Al's comments. Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_message_filter.cc

diff --git a/content/browser/renderer_host/render_message_filter.cc b/content/browser/renderer_host/render_message_filter.cc

index b408df066a64220ff0f8da5252b802a51840bd0e..b296d5f887a63baa792e72e37bfce0f8e8053755 100644

--- a/content/browser/renderer_host/render_message_filter.cc

+++ b/content/browser/renderer_host/render_message_filter.cc

@@ -753,8 +753,8 @@ void RenderMessageFilter::OnDownloadUrl(const IPC::Message& message,

const GURL& url,

const Referrer& referrer,

const string16& suggested_name) {

- DownloadSaveInfo save_info;

- save_info.suggested_name = suggested_name;

+ scoped_ptr<DownloadSaveInfo> save_info(new DownloadSaveInfo());

+ save_info->suggested_name = suggested_name;

scoped_ptr<net::URLRequest> request(

resource_context_->GetRequestContext()->CreateRequest(url, NULL));

request->set_referrer(referrer.url.spec());

@@ -768,7 +768,7 @@ void RenderMessageFilter::OnDownloadUrl(const IPC::Message& message,

render_process_id_,

message.routing_id(),

false,

- save_info,

+ save_info.Pass(),

ResourceDispatcherHostImpl::DownloadStartedCallback());

}