Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: content/browser/download/download_file_impl.cc

Issue 11028131: Shift passage of FileStream in downloads system to be by scoped_ptr<>. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Incorporated Al's comments. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/download/download_file_impl.h ('k') | content/browser/download/download_file_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/download/download_file_impl.cc
diff --git a/content/browser/download/download_file_impl.cc b/content/browser/download/download_file_impl.cc
index 7599900f108da8ba87e9bd1e7801bd9c8307528b..9ab0557f5b2cf786e8cfb77a25a8d9eeea8c931f 100644
--- a/content/browser/download/download_file_impl.cc
+++ b/content/browser/download/download_file_impl.cc
@@ -28,25 +28,25 @@ const int kUpdatePeriodMs = 500;
const int kMaxTimeBlockingFileThreadMs = 1000;
DownloadFileImpl::DownloadFileImpl(
- const DownloadCreateInfo* info,
+ scoped_ptr<DownloadCreateInfo> info,
scoped_ptr<content::ByteStreamReader> stream,
- DownloadRequestHandleInterface* request_handle,
+ scoped_ptr<DownloadRequestHandleInterface> request_handle,
scoped_refptr<DownloadManager> download_manager,
bool calculate_hash,
scoped_ptr<content::PowerSaveBlocker> power_save_blocker,
const net::BoundNetLog& bound_net_log)
- : file_(info->save_info.file_path,
+ : file_(info->save_info->file_path,
info->url(),
info->referrer_url,
info->received_bytes,
calculate_hash,
- info->save_info.hash_state,
- info->save_info.file_stream,
+ info->save_info->hash_state,
+ info->save_info->file_stream.Pass(),
bound_net_log),
stream_reader_(stream.Pass()),
id_(info->download_id),
default_download_directory_(info->default_download_directory),
- request_handle_(request_handle),
+ request_handle_(request_handle.Pass()),
download_manager_(download_manager),
bytes_seen_(0),
bound_net_log_(bound_net_log),
« no previous file with comments | « content/browser/download/download_file_impl.h ('k') | content/browser/download/download_file_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698