content/browser/download/base_file.cc - Issue 11028131: Shift passage of FileStream in downloads system to be by scoped_ptr<>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/base_file.cc

Issue 11028131: Shift passage of FileStream in downloads system to be by scoped_ptr<>. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Incorporated Al's comments. Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/download/base_file.cc

diff --git a/content/browser/download/base_file.cc b/content/browser/download/base_file.cc

index cc7871fcedde3d1a34ba8488651b4e4f96a7b20a..cad472f5adc3c337afba57b871a5d9b9098c8ba9 100644

--- a/content/browser/download/base_file.cc

+++ b/content/browser/download/base_file.cc

@@ -209,12 +209,12 @@ BaseFile::BaseFile(const FilePath& full_path,

int64 received_bytes,

bool calculate_hash,

const std::string& hash_state,

- const linked_ptr<net::FileStream>& file_stream,

+ scoped_ptr<net::FileStream> file_stream,

const net::BoundNetLog& bound_net_log)

: full_path_(full_path),

source_url_(source_url),

referrer_url_(referrer_url),

- file_stream_(file_stream),

+ file_stream_(file_stream.Pass()),

bytes_so_far_(received_bytes),

start_tick_(base::TimeTicks::Now()),

calculate_hash_(calculate_hash),

« no previous file with comments | « content/browser/download/base_file.h ('k') | content/browser/download/base_file_unittest.cc » ('j') | no next file with comments »